Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2106683002: Remove Node.rootNode (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
rkaplow, kochi
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Node.rootNode Before shipping Shadow DOM v1, we have to remove this feature because Node.rootNode is guarded by ShadowDOMV1 flag. See also https://bugs.chromium.org/p/chromium/issues/detail?id=608006. Ship of Node.rootNode was reverted there. BUG=531990 Committed: https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557 Cr-Commit-Position: refs/heads/master@{#402697}

Patch Set 1 #

Patch Set 2 : Rebase failing tests #

Total comments: 2

Patch Set 3 : leave the line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -91 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/dom/historical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/node-rootNode.html View 1 chunk +0 lines, -84 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106683002/1
4 years, 5 months ago (2016-06-28 04:22:53 UTC) #2
hayato
PTAL. Adding rkaplow@ to a reviewer for histgrams.xml.
4 years, 5 months ago (2016-06-28 04:30:57 UTC) #5
kochi
What's the plan for replacing Node.rootNode with Node.getRootNode()? https://github.com/whatwg/dom/issues/241
4 years, 5 months ago (2016-06-28 04:39:47 UTC) #6
hayato
That should be done later.
4 years, 5 months ago (2016-06-28 04:44:27 UTC) #7
kochi
On 2016/06/28 04:44:27, hayato wrote: > That should be done later. I see, because it ...
4 years, 5 months ago (2016-06-28 04:58:24 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246444)
4 years, 5 months ago (2016-06-28 05:55:20 UTC) #10
hayato
Let me fix falling layout tests.
4 years, 5 months ago (2016-06-28 06:03:02 UTC) #11
hayato
Rebase failing tests
4 years, 5 months ago (2016-06-28 06:08:38 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106683002/20001
4 years, 5 months ago (2016-06-28 06:08:54 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 08:35:05 UTC) #16
rkaplow
lgtm https://codereview.chromium.org/2106683002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2106683002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode75541 tools/metrics/histograms/histograms.xml:75541: - <int value="1154" label="NodeRootNode"/> prefer leaving the line ...
4 years, 5 months ago (2016-06-28 14:40:33 UTC) #17
hayato
leave the line
4 years, 5 months ago (2016-06-29 01:35:05 UTC) #19
hayato
https://codereview.chromium.org/2106683002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2106683002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode75541 tools/metrics/histograms/histograms.xml:75541: - <int value="1154" label="NodeRootNode"/> Thanks! Done.
4 years, 5 months ago (2016-06-29 01:35:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106683002/40001
4 years, 5 months ago (2016-06-29 01:36:52 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 03:07:34 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 03:11:03 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5401b41c540d2ace9e9d773ece97a615729b6557
Cr-Commit-Position: refs/heads/master@{#402697}

Powered by Google App Engine
This is Rietveld 408576698