Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2106643002: Add jialiul and vakh to some Safe Browsing OWNERS (Closed)

Created:
4 years, 5 months ago by Nathan Parker
Modified:
4 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, arv+watch_chromium.org, Jialiu Lin, vakh (use Gerrit instead)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add jialiul and vakh to some Safe Browsing OWNERS CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/860ad78e988bf02ccd2fd8d2667f780e1b7d1519 Cr-Commit-Position: refs/heads/master@{#402572}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add vakh to _db #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/resources/safe_browsing/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Nathan Parker
4 years, 5 months ago (2016-06-28 00:05:47 UTC) #3
vakh (use Gerrit instead)
lgtm https://codereview.chromium.org/2106643002/diff/1/components/safe_browsing_db/OWNERS File components/safe_browsing_db/OWNERS (right): https://codereview.chromium.org/2106643002/diff/1/components/safe_browsing_db/OWNERS#newcode4 components/safe_browsing_db/OWNERS:4: # For reporting-related changes: Could you please consider ...
4 years, 5 months ago (2016-06-28 00:13:00 UTC) #5
Nathan Parker
https://codereview.chromium.org/2106643002/diff/1/components/safe_browsing_db/OWNERS File components/safe_browsing_db/OWNERS (right): https://codereview.chromium.org/2106643002/diff/1/components/safe_browsing_db/OWNERS#newcode4 components/safe_browsing_db/OWNERS:4: # For reporting-related changes: On 2016/06/28 00:13:00, vakh wrote: ...
4 years, 5 months ago (2016-06-28 17:26:23 UTC) #6
mattm
lgtm
4 years, 5 months ago (2016-06-28 18:53:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106643002/20001
4 years, 5 months ago (2016-06-28 19:03:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 22:20:55 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:24:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/860ad78e988bf02ccd2fd8d2667f780e1b7d1519
Cr-Commit-Position: refs/heads/master@{#402572}

Powered by Google App Engine
This is Rietveld 408576698