appengine/cr-buildbucket/proto/project_config.proto - Issue 2106633002: swarmbucket: non-string properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cr-buildbucket/proto/project_config.proto

Issue 2106633002: swarmbucket: non-string properties (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: swarmbucket: non-string properties Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cr-buildbucket/proto/project_config.proto

diff --git a/appengine/cr-buildbucket/proto/project_config.proto b/appengine/cr-buildbucket/proto/project_config.proto

index 0edc1849d315274899765781e92c558b4cfc67e0..60ae4d523b48ae16a05957ccac7182d8a0f0b27b 100644

--- a/appengine/cr-buildbucket/proto/project_config.proto

+++ b/appengine/cr-buildbucket/proto/project_config.proto

@@ -37,7 +37,17 @@ message Swarming {

optional string name = 2;

// colon-separated build properties to set.

// A property can be overriden by "properties" build parameter.

+ //

+ // Use this field for string properties and use properties_j for other

+ // types.

repeated string properties = 3;

+ // Same as properties, but the value must valid JSON. For example

Vadim Sh. 2016/06/28 00:10:35 is it allowed to have "a:{\"b\":\"c\"}"?

nodir 2016/06/28 00:42:38 yes, not prohibited, but not encouraged either (by

+ // properties_j: "a:1"

+ // means property a is a number 1, not string "1".

+ //

+ // Fields properties and properties_j can be used together, but cannot both

+ // specify values for same property.

+ repeated string properties_j = 4;

}

message Builder {