Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: appengine/cr-buildbucket/proto/project_config.proto

Issue 2106633002: swarmbucket: non-string properties (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: swarmbucket: non-string properties Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Swarming Authors. All rights reserved. 1 // Copyright 2015 The Swarming Authors. All rights reserved.
2 // Use of this source code is governed by the Apache v2.0 license that can be 2 // Use of this source code is governed by the Apache v2.0 license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Schemas for project configs. 5 // Schemas for project configs.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 package buildbucket; 9 package buildbucket;
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 // Configuration of buildbucket-swarming integration for one bucket. 31 // Configuration of buildbucket-swarming integration for one bucket.
32 message Swarming { 32 message Swarming {
33 message Recipe { 33 message Recipe {
34 // Repository URL of the recipe package. 34 // Repository URL of the recipe package.
35 optional string repository = 1; 35 optional string repository = 1;
36 // Name of the recipe to run. 36 // Name of the recipe to run.
37 optional string name = 2; 37 optional string name = 2;
38 // colon-separated build properties to set. 38 // colon-separated build properties to set.
39 // A property can be overriden by "properties" build parameter. 39 // A property can be overriden by "properties" build parameter.
40 //
41 // Use this field for string properties and use properties_j for other
42 // types.
40 repeated string properties = 3; 43 repeated string properties = 3;
44 // Same as properties, but the value must valid JSON. For example
Vadim Sh. 2016/06/28 00:10:35 is it allowed to have "a:{\"b\":\"c\"}"?
nodir 2016/06/28 00:42:38 yes, not prohibited, but not encouraged either (by
45 // properties_j: "a:1"
46 // means property a is a number 1, not string "1".
47 //
48 // Fields properties and properties_j can be used together, but cannot both
49 // specify values for same property.
50 repeated string properties_j = 4;
41 } 51 }
42 52
43 message Builder { 53 message Builder {
44 // Name of the builder. Will be propagated to "builder" build tag and 54 // Name of the builder. Will be propagated to "builder" build tag and
45 // "buildername" recipe property. 55 // "buildername" recipe property.
46 optional string name = 1; 56 optional string name = 1;
47 // Builder category. Will be used for visual grouping, for example in Code R eview. 57 // Builder category. Will be used for visual grouping, for example in Code R eview.
48 optional string category = 6; 58 optional string category = 6;
49 // Will be become to swarming task tags. 59 // Will be become to swarming task tags.
50 // Each tag will end up in "swarming_tag" buildbucket tag, for example 60 // Each tag will end up in "swarming_tag" buildbucket tag, for example
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 repeated Acl acls = 2; 104 repeated Acl acls = 2;
95 // Buildbucket-swarming integration. 105 // Buildbucket-swarming integration.
96 optional Swarming swarming = 3; 106 optional Swarming swarming = 3;
97 } 107 }
98 108
99 // Schema of buildbucket.cfg file, a project config. 109 // Schema of buildbucket.cfg file, a project config.
100 message BuildbucketCfg { 110 message BuildbucketCfg {
101 // All buckets defined for this project. 111 // All buckets defined for this project.
102 repeated Bucket buckets = 1; 112 repeated Bucket buckets = 1;
103 } 113 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698