Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 21066002: Revert 214177 "Use plain sh instead of bash in the git template ..." (Closed)

Created:
7 years, 4 months ago by Isaac (away)
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 214177 "Use plain sh instead of bash in the git template ..." > Use plain sh instead of bash in the git template hooks. > > The scripts are simple enough and should work fine under any POSIX shell, > which is particularly helpful when one is using `gclient sync' on a platform > that does not have /bin/bash (ie. it's installed in another location or not > present at all), since the hooks are automatically added to the git > checkouts. > > While here, just `exec' the scripts directly instead of invoking another > shell by hand and remove the redundant `exit 0' lines. > > R=cmp@chromium.org,dpranke@chromium.org,szager@chromium.org TBR=raphael.kubo.da.costa@intel.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214178

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Isaac (away)
7 years, 4 months ago (2013-07-29 12:09:52 UTC) #1
Isaac (away)
7 years, 4 months ago (2013-07-29 12:09:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r214178.

Powered by Google App Engine
This is Rietveld 408576698