Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 21065007: Revert 214755 "Clean up PnaclTranslationCache interface" (Closed)

Created:
7 years, 4 months ago by Derek Schuff
Modified:
7 years, 4 months ago
Reviewers:
Derek Schuff
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 214755 "Clean up PnaclTranslationCache interface" > Clean up PnaclTranslationCache interface > > This CL augments PnaclTranslationCache's public interface into a state > where it can be used by the PnaclHost. In particular, it adds GetKey > which generates a cache key from a cache_info object, and it switches > to using net::DrainableIOBuffer to transfer nexe data, which both > simplifies the implementation and reduces the number of times the data > needs to be copied. > > R=jvoung@chromium.org > BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372 > TEST= unit_tests --gtest_filter=PnaclTranslationCache* > > Review URL: https://chromiumcodereview.appspot.com/21075004 TBR=tbreisacher@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -257 lines) Patch
M trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.h View 2 chunks +8 lines, -23 lines 0 comments Download
M trunk/src/chrome/browser/nacl_host/pnacl_translation_cache.cc View 13 chunks +71 lines, -118 lines 0 comments Download
M trunk/src/chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc View 7 chunks +14 lines, -116 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
7 years, 4 months ago (2013-07-31 17:21:15 UTC) #1
Derek Schuff
Committed patchset #1 manually as r214762.
7 years, 4 months ago (2013-07-31 17:21:25 UTC) #2
Mark Seaborn
7 years, 4 months ago (2013-07-31 17:50:06 UTC) #3
Message was sent while issue was closed.
Why was the change reverted?  Please put an explanation in the commit message or
in the review, otherwise no-one can tell from the change history why a change
was reverted.

Powered by Google App Engine
This is Rietveld 408576698