Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: src/hydrogen.h

Issue 21065003: Turn mark deoptimize on undefined into a proper HPhase. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 Isolate* isolate() const { return isolate_; } 309 Isolate* isolate() const { return isolate_; }
310 Zone* zone() const { return zone_; } 310 Zone* zone() const { return zone_; }
311 CompilationInfo* info() const { return info_; } 311 CompilationInfo* info() const { return info_; }
312 312
313 const ZoneList<HBasicBlock*>* blocks() const { return &blocks_; } 313 const ZoneList<HBasicBlock*>* blocks() const { return &blocks_; }
314 const ZoneList<HPhi*>* phi_list() const { return phi_list_; } 314 const ZoneList<HPhi*>* phi_list() const { return phi_list_; }
315 HBasicBlock* entry_block() const { return entry_block_; } 315 HBasicBlock* entry_block() const { return entry_block_; }
316 HEnvironment* start_environment() const { return start_environment_; } 316 HEnvironment* start_environment() const { return start_environment_; }
317 317
318 void FinalizeUniqueValueIds(); 318 void FinalizeUniqueValueIds();
319 void MarkDeoptimizeOnUndefined();
320 bool ProcessArgumentsObject(); 319 bool ProcessArgumentsObject();
321 void OrderBlocks(); 320 void OrderBlocks();
322 void AssignDominators(); 321 void AssignDominators();
323 void SetupInformativeDefinitions(); 322 void SetupInformativeDefinitions();
324 void RestoreActualValues(); 323 void RestoreActualValues();
325 324
326 // Returns false if there are phi-uses of the arguments-object 325 // Returns false if there are phi-uses of the arguments-object
327 // which are not supported by the optimizing compiler. 326 // which are not supported by the optimizing compiler.
328 bool CheckArgumentsPhiUses(); 327 bool CheckArgumentsPhiUses();
329 328
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 private: 456 private:
458 HConstant* GetConstant(SetOncePointer<HConstant>* pointer, 457 HConstant* GetConstant(SetOncePointer<HConstant>* pointer,
459 int32_t integer_value); 458 int32_t integer_value);
460 459
461 template<class Phase> 460 template<class Phase>
462 void Run() { 461 void Run() {
463 Phase phase(this); 462 Phase phase(this);
464 phase.Run(); 463 phase.Run();
465 } 464 }
466 465
467 void RecursivelyMarkPhiDeoptimizeOnUndefined(HPhi* phi);
468 void CheckForBackEdge(HBasicBlock* block, HBasicBlock* successor); 466 void CheckForBackEdge(HBasicBlock* block, HBasicBlock* successor);
469 void SetupInformativeDefinitionsInBlock(HBasicBlock* block); 467 void SetupInformativeDefinitionsInBlock(HBasicBlock* block);
470 void SetupInformativeDefinitionsRecursively(HBasicBlock* block); 468 void SetupInformativeDefinitionsRecursively(HBasicBlock* block);
471 void EliminateRedundantBoundsChecksUsingInductionVariables(); 469 void EliminateRedundantBoundsChecksUsingInductionVariables();
472 470
473 Isolate* isolate_; 471 Isolate* isolate_;
474 int next_block_id_; 472 int next_block_id_;
475 HBasicBlock* entry_block_; 473 HBasicBlock* entry_block_;
476 HEnvironment* start_environment_; 474 HEnvironment* start_environment_;
477 ZoneList<HBasicBlock*> blocks_; 475 ZoneList<HBasicBlock*> blocks_;
(...skipping 1688 matching lines...) Expand 10 before | Expand all | Expand 10 after
2166 EmbeddedVector<char, 64> filename_; 2164 EmbeddedVector<char, 64> filename_;
2167 HeapStringAllocator string_allocator_; 2165 HeapStringAllocator string_allocator_;
2168 StringStream trace_; 2166 StringStream trace_;
2169 int indent_; 2167 int indent_;
2170 }; 2168 };
2171 2169
2172 2170
2173 } } // namespace v8::internal 2171 } } // namespace v8::internal
2174 2172
2175 #endif // V8_HYDROGEN_H_ 2173 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698