Issue 2106493002: PPC: Disable constantpool before calling Stub without frame

Issue 2106493002: PPC: Disable constantpool before calling Stub without frame (Closed)

Created:
4 years, 5 months ago by JaideepBajwa

Modified:
4 years, 5 months ago

Reviewers:
MTBrandyberry, michael_dawson, john.yan, JoranSiu

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

PPC: Disable constantpool before calling Stub without frame Constantpool register is being used with no frame, and therefore it points to its parent stub's constantpool causing segfault. Disable constantpool before CallStub if frame not set. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/ea844f9aac0f5363e3590e15ea2fefd999905b9f Cr-Commit-Position: refs/heads/master@{#37300}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/compiler/ppc/code-generator-ppc.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106493002/1

4 years, 5 months ago (2016-06-27 19:21:27 UTC) #4

commit-bot: I haz the power

4 years, 5 months ago (2016-06-27 19:44:56 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ea844f9aac0f5363e3590e15ea2fefd999905b9f
Cr-Commit-Position: refs/heads/master@{#37300}