Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: BUILD.gn

Issue 2106423002: [gn] Automatically derive build configs in test runner. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Presubmit + more robust json loading Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/run-tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 466fac63cce2be51c68e85965eb925167010be55..1f6b9365b575d8327857c4d75543f9e30bc2cee3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -617,6 +617,26 @@ action("run_mksnapshot") {
}
}
+action("v8_dump_build_config") {
+ script = "tools/testrunner/utils/dump_build_config.py"
+ outputs = [ "$root_out_dir/v8_build_config.json" ]
+ args = [
+ rebase_path("$root_out_dir/v8_build_config.json", root_build_dir),
+ "dcheck_always_on=$dcheck_always_on",
+ "is_asan=$is_asan",
+ "is_cfi=$is_cfi",
+ "is_component_build=$is_component_build",
+ "is_debug=$is_debug",
+ "is_msan=$is_msan",
+ "is_tsan=$is_tsan",
+ "target_cpu=\"$target_cpu\"",
+ "v8_enable_i18n_support=$v8_enable_i18n_support",
+ "v8_target_cpu=\"$v8_target_cpu\"",
+ "v8_use_snapshot=$v8_use_snapshot",
+ ]
+}
+
+
###############################################################################
# Source Sets (aka static libraries)
#
@@ -2098,6 +2118,8 @@ if (is_component_build) {
"src/v8dll-main.cc",
]
+ deps = [ ":v8_dump_build_config" ]
+
public_deps = [
":v8_base",
":v8_maybe_snapshot",
@@ -2109,6 +2131,8 @@ if (is_component_build) {
}
} else {
group("v8") {
+ deps = [ ":v8_dump_build_config" ]
+
public_deps = [
":v8_base",
":v8_maybe_snapshot",
« no previous file with comments | « no previous file | tools/run-tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698