Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: tools/testrunner/utils/dump_build_config.py

Issue 2106423002: [gn] Automatically derive build configs in test runner. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: [gn] Automatically derive build configs in test runner. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/run-tests.py ('K') | « tools/run-tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/utils/dump_build_config.py
diff --git a/tools/testrunner/utils/dump_build_config.py b/tools/testrunner/utils/dump_build_config.py
new file mode 100644
index 0000000000000000000000000000000000000000..01acadc123955d71f3215d648e4e07b37cc50008
--- /dev/null
+++ b/tools/testrunner/utils/dump_build_config.py
@@ -0,0 +1,28 @@
+# Copyright 2016 The V8 project authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Writes a dictionary to a json file with the passed key-value pairs.
+
+Expected to be called like:
+dump_build_config.py path/to/file.json [key1=value1 ...]
+
+The values are expected to be valid json. E.g. true is a boolean and "true" is
+the string "true".
+"""
+
+import json
+import os
+import sys
+
+assert len(sys.argv) > 1
+assert os.path.exists(sys.argv[1])
+assert os.path.isdir(sys.argv[1])
+
+def as_json(kv):
+ assert '=' in kv
+ k, v = kv.split('=', 1)
+ return k, json.loads(v)
+
+with open(os.path.join(sys.argv[1], 'v8_build_config.json'), 'w') as f:
vogelheim 2016/06/30 11:08:02 os.path.join(...): This is not what the header com
Michael Achenbach 2016/06/30 11:47:50 Done. But as a consequence I needed to remove the
vogelheim 2016/06/30 12:09:39 I guess you could use os.path.absname to first con
+ json.dump(dict(as_json(kv) for kv in sys.argv[2:]), f)
vogelheim 2016/06/30 11:08:02 please add a try-except for IOError, and return -1
Michael Achenbach 2016/06/30 11:47:49 Not sure what you mean. When an exception is throw
vogelheim 2016/06/30 12:09:39 Ah, that is what I meant. I had assumed an uncaugh
« tools/run-tests.py ('K') | « tools/run-tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698