ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm - Issue 2106413003: UpdatePasswordInfoBarController for update password UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

Issue 2106413003: UpdatePasswordInfoBarController for update password UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@update_delegate

Patch Set: Nit fixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/BUILD.gn ('k') | ios/chrome/browser/passwords/update_password_infobar_controller.h » ('j') | ios/chrome/browser/passwords/update_password_infobar_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

diff --git a/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm b/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

index 4b1dde1fddc47a14caa402fc37b5c3913b17a521..c41b53734d67124ae9d7ee6efc1e1d0c765dd1a7 100644

--- a/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

+++ b/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

@@ -14,8 +14,8 @@

#include "components/password_manager/core/browser/password_form_manager.h"

#include "components/password_manager/core/browser/password_manager_constants.h"

#include "components/strings/grit/components_strings.h"

-#import "ios/chrome/browser/infobars/confirm_infobar_controller.h"

#include "ios/chrome/browser/infobars/infobar.h"

+#import "ios/chrome/browser/passwords/update_password_infobar_controller.h"

#include "ios/chrome/grit/ios_chromium_strings.h"

#include "ios/chrome/grit/ios_google_chrome_strings.h"

#include "ios/chrome/grit/ios_strings.h"

@@ -32,10 +32,8 @@ void IOSChromeUpdatePasswordInfoBarDelegate::Create(

auto delegate = base::WrapUnique(new IOSChromeUpdatePasswordInfoBarDelegate(

is_smart_lock_branding_enabled, std::move(form_manager)));

std::unique_ptr<InfoBarIOS> infobar(new InfoBarIOS(std::move(delegate)));

- // TODO(crbug.com/622244): Replace ConfirmInfoBarController with update

- // password controller class.

- base::scoped_nsobject<ConfirmInfoBarController> controller(

- [[ConfirmInfoBarController alloc] initWithDelegate:infobar.get()]);

+ base::scoped_nsobject<UpdatePasswordInfoBarController> controller(

marq (ping after 24h) 2016/06/30 16:17:38 Per the ARC FAQ, we prefer autorelease to scoped_n

Jackie Quinn 2016/07/01 12:01:58 Done.

+ [[UpdatePasswordInfoBarController alloc] initWithDelegate:infobar.get()]);

infobar->SetController(controller);

infobar_manager->AddInfoBar(std::move(infobar));

}