Issue 2106413002: Removed fdlibm.js, as it is now an empty shell.

Issue 2106413002: Removed fdlibm.js, as it is now an empty shell. (Closed)

Created:
4 years, 5 months ago by mvstanton

Modified:
4 years, 5 months ago

Reviewers:
Benedikt Meurer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Removed fdlibm.js, as it is now an empty shell. BUG= Committed: https://crrev.com/47f543305e396c8e10cfbff4a510f55ea2fedcfa Cr-Commit-Position: refs/heads/master@{#37510}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -60 lines)			Patch
D	src/third_party/fdlibm/LICENSE	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	src/third_party/fdlibm/README.v8	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	src/third_party/fdlibm/fdlibm.js	View	1 chunk	+0 lines, -36 lines	0 comments	Download

Total messages: 10 (3 generated)

mvstanton

Hi Benedikt, I'll remove the files as well. Thx for the look, --Mike

4 years, 5 months ago (2016-06-30 10:03:29 UTC) #2

Benedikt Meurer

We need to hookup LICENSE.fdlibm w/ Chrome first. See https://cs.chromium.org/chromium/src/tools/licenses.py?q=fdlibm&sq=package:chromium&l=120&dr=C

4 years, 5 months ago (2016-06-30 10:18:33 UTC) #3

mvstanton

Hi Benedikt, Chrome license hooked up, as they say (https://codereview.chromium.org/2111913002/). PTAL, --Mike

4 years, 5 months ago (2016-07-04 21:18:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106413002/1

4 years, 5 months ago (2016-07-05 03:31:49 UTC) #7

commit-bot: I haz the power

4 years, 5 months ago (2016-07-05 03:57:30 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/47f543305e396c8e10cfbff4a510f55ea2fedcfa
Cr-Commit-Position: refs/heads/master@{#37510}