Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2106393002: Fix double canonicalization (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix double canonicalization This turns the blacklist back into a white-list adding all binary operations as allowed operations. The one known fix is that it forces canonicalization of the double-hole as double constant. BUG=chromium:621147 Committed: https://crrev.com/c17b44bd3a3ae84fa2c39afd7ebbfdfbcbcfefed Cr-Commit-Position: refs/heads/master@{#37452}

Patch Set 1 #

Patch Set 2 : test #

Total comments: 1

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M src/crankshaft/hydrogen-instructions.cc View 1 2 5 chunks +15 lines, -10 lines 0 comments Download
A test/mjsunit/regress/regress-double-canonicalization.js View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-06-30 09:44:48 UTC) #2
Jakob Kummerow
lgtm https://codereview.chromium.org/2106393002/diff/20001/test/mjsunit/regress/regress-double-canonicalization.js File test/mjsunit/regress/regress-double-canonicalization.js (right): https://codereview.chromium.org/2106393002/diff/20001/test/mjsunit/regress/regress-double-canonicalization.js#newcode23 test/mjsunit/regress/regress-double-canonicalization.js:23: assertTrue(isNaN(array[0])); Do you also want to assertTrue(array[0] !== ...
4 years, 5 months ago (2016-06-30 09:53:51 UTC) #3
Jakob Kummerow
still LGTM.
4 years, 5 months ago (2016-06-30 11:03:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106393002/40001
4 years, 5 months ago (2016-06-30 14:27:50 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 15:15:54 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 15:18:28 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c17b44bd3a3ae84fa2c39afd7ebbfdfbcbcfefed
Cr-Commit-Position: refs/heads/master@{#37452}

Powered by Google App Engine
This is Rietveld 408576698