Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2106363002: MD History: Add title to item menu button (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Add title to item menu button This matches the behavior of the existing history page. BUG=623014 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/710f4b3005d697706b7c6e8b7b71e8de83f64a80 Cr-Commit-Position: refs/heads/master@{#403387}

Patch Set 1 #

Patch Set 2 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/md_history/history_item.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tsergeant
4 years, 5 months ago (2016-06-30 07:09:41 UTC) #3
Dan Beam
lgtm but moreActions is a better name for this (IMO) than actionButton
4 years, 5 months ago (2016-06-30 23:26:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106363002/20001
4 years, 5 months ago (2016-07-01 00:51:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 01:53:49 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 01:57:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/710f4b3005d697706b7c6e8b7b71e8de83f64a80
Cr-Commit-Position: refs/heads/master@{#403387}

Powered by Google App Engine
This is Rietveld 408576698