Implement "copy_bundle_data" tool without using a python script.

build/toolchain/mac/BUILD.gn

Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 231a546891d463367ebcdce18584116f5d5f92fa..66770d37af9d47c21cb4e49d1facb5729eae4a33 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -64,7 +64,6 @@ tool_versions =
     exec_script("get_tool_mtime.py",
                 rebase_path([
                               "//build/toolchain/mac/compile_xcassets.py",
-                              "//build/toolchain/mac/copy_bundle_data.py",
                               "//build/toolchain/mac/filter_libtool.py",
                               "//build/toolchain/mac/linker_driver.py",
                             ],
@@ -307,14 +306,36 @@ template("mac_toolchain") {
     }
 
     tool("copy_bundle_data") {
-      if (is_ios) {
-        _extra_args = "--strings-format=binary1"
-      } else {
-        _extra_args = ""
+      # copy_command use hardlink if possible but this does not work with
+      # directories. If source is a directory, instead use "pax" to create
+      # the same tree structure using hardlinks to individual files (this
+      # preserve symbolic links too) as recommended in the replies to the
+      # question at http://serverfault.com/q/209888/43689 ("cp -al" isn't
+      # available on macOS).
+      #
+      # According to the man page for pax, the commands to use to clone
+      # olddir to newdir using pax are the following:
+      #
+      #   $ mkdir newdir
+      #   $ cd olddir
+      #   $ pax -rwl . ../newdir
+      #
+      # The _copydir command does exactly that but use an absolute path
+      # constructed using shell variable $OLDPWD (automatically set when
+      # cd is used) as computing the relative path is a bit complex.
+      _copydir = "mkdir -p {{output}} && cd {{source}} && " +

[Robert Sesek, 2016/07/01 15:12:17]

I assume this cd is safe because we're running in a subshell.

Alternatively, could you build the absolute path using $(pwd -P) ?

[sdefresne, 2016/07/04 09:12:53]

Yes, the "cd" is safe as this is only changing the path for the shell, not for
ninja itself.
I need the "cd" because if I invoke pax with a source path that is not ".", then
it copies the structures in the output directory, for example, if we have the
following directories:

src/A
  file1
  file2

and invoke pax like this to copy src/A to dst/A:

mkdir -p dst/A && pax -rwl src/A dst/A

then we'll end up with the following directory structure:

dst/A/src/A
  file1
  file2

instead of

dst/A
  file1
  file2

According to the man page, this is expected and this is why the recommend
instead to use the following command:

mkdir -p dst/A && cd src/A && pax -rwl . ../../dst/A

So I have a choice between using $(pwd) or $OLDPWD and I chose OLDPWD because it
is available and allows me to avoid invoking another subshell (so should be
slightly faster as there is one less process to create).

+                 "pax -rwl . \$OLDPWD/{{output}}"

[Robert Sesek, 2016/07/01 15:12:17]

The substitution will handle shell escaping and quoting, but I don't think the
bash variable substitution will. So this variable should probably be quoted.

[sdefresne, 2016/07/04 09:12:53]

Done.

+      _command = "if [[ -d {{source}} ]]; then " + _copydir + "; else " +
+                 copy_command + "; fi"
+
+      _convert_strings = is_ios
+      if (_convert_strings) {
+        _convert = "plutil -convert binary1 -o {{output}} {{source}}"
+        _command = "case {{source}} in " + "*.strings) " + _convert + ";; " +
+                   "*) " + _command + ";; esac"
       }
-      _tool = rebase_path("//build/toolchain/mac/copy_bundle_data.py",
-                          root_build_dir)
-      command = "TOOL_VERSION=${tool_versions.copy_bundle_data} python $_tool ${_extra_args} {{source}} {{output}}"
+
+      command = "rm -rf {{output}} && " + _command
       description = "COPY_BUNDLE_DATA {{source}} {{output}}"
       pool = ":bundle_pool($default_toolchain)"
     }