Implement "copy_bundle_data" tool without using a python script.

build/toolchain/mac/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # TODO(brettw) Use "gcc_toolchain.gni" like the Linux toolchains. This requires
 # some enhancements since the commands on Mac are slightly different than on
 # Linux.
 
 import("../goma.gni")
 import("//build/config/clang/clang.gni")
@@ skipping 46 matching lines @@
 # proper input-dirty checking, but that could be expensive. Instead, use a
 # script to get the tool scripts' modification time to use as the version.
 # This won't cause a re-generation of GN files when the tool script changes
 # but it will cause edges to be marked as dirty if the ninja files are
 # regenerated. See https://crbug.com/619083 for details. A proper fix
 # would be to have inputs to tools (https://crbug.com/621119).
 tool_versions =
     exec_script("get_tool_mtime.py",
                 rebase_path([
                               "//build/toolchain/mac/compile_xcassets.py",
-                              "//build/toolchain/mac/copy_bundle_data.py",
                               "//build/toolchain/mac/filter_libtool.py",
                               "//build/toolchain/mac/linker_driver.py",
                             ],
                             root_build_dir),
                 "trim scope")
 
 # Work around for unused variable warning in template https://crbug.com/395883.
 assert(tool_versions != "")
 
 # Shared toolchain definition. Invocations should set toolchain_os to set the
@@ skipping 222 matching lines @@
     tool("stamp") {
       command = stamp_command
       description = stamp_description
     }
     tool("copy") {
       command = copy_command
       description = copy_description
     }
 
     tool("copy_bundle_data") {
-      if (is_ios) {
-        _extra_args = "--strings-format=binary1"
-      } else {
-        _extra_args = ""
+      _command = "if [[ -d {{source}} ]]; then " +

[Robert Sesek, 2016/06/30 17:28:02]

This is missing the rm step first.

[sdefresne, 2016/07/01 11:12:29]

Fixed.

+                 "rsync --recursive --perms --links {{source}}/ {{output}}; " +
+                 "else " + copy_command + "; fi"
+
+      _convert_strings = is_ios
+      if (_convert_strings) {

[Robert Sesek, 2016/06/30 17:28:02]

Should we just make string conversion a separate step at this point, and not
make it a part of COPY_BUNDLE_DATA? That would align with how we do xib and
xcasset compilation too.

[sdefresne, 2016/07/01 11:12:29]

I think we should do it as a separate step, however, there are 50+ such files
and I'll prefer to do it as a followup CLs as this CL is a radical improvement
for build time already.

[Robert Sesek, 2016/07/01 15:12:17]

Yes, fine to do that in a follow up. Can you file a bug?

+        _command =
+            "case {{source}} in " +
+            "*.strings) plutil -convert binary1 -o {{output}} {{source}};; " +
+            "*) " + _command + ";; esac"
       }
-      _tool = rebase_path("//build/toolchain/mac/copy_bundle_data.py",
-                          root_build_dir)
-      command = "TOOL_VERSION=${tool_versions.copy_bundle_data} python $_tool ${_extra_args} {{source}} {{output}}"
+
+      command = _command
       description = "COPY_BUNDLE_DATA {{source}} {{output}}"
       pool = ":bundle_pool($default_toolchain)"
     }
     tool("compile_xcassets") {
       _tool = rebase_path("//build/toolchain/mac/compile_xcassets.py",
                           root_build_dir)
       if (is_ios) {
         _sdk_name = ios_sdk_name
         _min_deployment_target = ios_deployment_target
       } else {
@@ skipping 44 matching lines @@
 
 mac_toolchain("ios_clang_x86") {
   toolchain_cpu = "x86"
   toolchain_os = "ios"
 }
 
 mac_toolchain("ios_clang_x64") {
   toolchain_cpu = "x64"
   toolchain_os = "ios"
 }