Enable Update Password UI on iOS behind a flag

ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/passwords/ios_chrome_password_manager_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "components/autofill/core/common/password_form.h"
 #include "components/browser_sync/browser/profile_sync_service.h"
 #include "components/keyed_service/core/service_access_type.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager_util.h"
 #include "components/password_manager/core/common/password_manager_pref_names.h"
 #include "components/signin/core/browser/signin_manager_base.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
+#include "ios/chrome/browser/experimental_flags.h"
 #include "ios/chrome/browser/passwords/ios_chrome_password_store_factory.h"
 #include "ios/chrome/browser/signin/signin_manager_factory.h"
 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
+

[vabr (Chromium), 2016/07/05 14:30:57]

nit: Why this blank line? Normally the non-system #includes are in one block
except for #ifdef parts.

[Jackie Quinn, 2016/07/05 15:12:36]

user error. Fixed.

 #include "url/gurl.h"
 
 using password_manager::PasswordFormManager;
 using password_manager::PasswordStore;
 using password_manager::PasswordSyncState;
 
 namespace {
 
 const sync_driver::SyncService* GetSyncService(
     ios::ChromeBrowserState* browser_state) {
@@ skipping 36 matching lines @@
   NOTIMPLEMENTED();
   return false;
 }
 
 bool IOSChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
     std::unique_ptr<PasswordFormManager> form_to_save,
     password_manager::CredentialSourceType type,
     bool update_password) {
   if (form_to_save->IsBlacklisted())
     return false;
-  [delegate_ showSavePasswordInfoBar:std::move(form_to_save)];
+
+  if (experimental_flags::IsUpdatePasswordUIEnabled() && update_password) {
+    [delegate_ showUpdatePasswordInfoBar:std::move(form_to_save)];
+  } else {
+    [delegate_ showSavePasswordInfoBar:std::move(form_to_save)];

[vabr (Chromium), 2016/07/05 14:30:57]

This seems like it would start showing the "save password" infobar for password
updates if the flag is off. It should be rather:
if (update_password) {
  if (/*flag set*/)
    /*show update infobar*/
} else {
  /*show save infobar*/
}

[Jackie Quinn, 2016/07/05 15:12:36]

I had it this way since it was always showing the save infobar anyways. Happy to
change it though :-)

[vabr (Chromium), 2016/07/05 15:32:17]

Oh, you are right, Jackie, your patch set 4 keeps the original behaviour. In
that case I would suggest to keep it (= what you had in patch set 4). Sorry for
the back and forth.

Just out of curiosity, does iOS (without the change password support enabled)
prompt to save if you update a password? Looking at Android, in its section of
ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword, it does exactly
what you do here in patch set 4. Still, it updates silently. I have no idea why,
need to have a look later.

+  }
+
   return true;
 }
 
 void IOSChromePasswordManagerClient::AutomaticPasswordSave(
     std::unique_ptr<PasswordFormManager> saved_form_manager) {
   NOTIMPLEMENTED();
 }
 
 bool IOSChromePasswordManagerClient::IsOffTheRecord() const {
   return (delegate_.browserState)->IsOffTheRecord();
@@ skipping 33 matching lines @@
 }
 
 const GURL& IOSChromePasswordManagerClient::GetLastCommittedEntryURL() const {
   return delegate_.lastCommittedURL;
 }
 
 const password_manager::CredentialsFilter*
 IOSChromePasswordManagerClient::GetStoreResultFilter() const {
   return &credentials_filter_;
 }