Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2106333004: Fix raw_io input placeholders not using unicode. (Closed)

Created:
4 years, 5 months ago by martiniss
Modified:
4 years, 5 months ago
Reviewers:
estaab
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix raw_io input placeholders not using unicode. Committed: https://github.com/luci/recipes-py/commit/97de2622765bdf58b51b827f9e9ba07b19e0a1e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M recipe_modules/raw_io/api.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
martiniss
PTAL Still needed to fix the autoroller :(
4 years, 5 months ago (2016-06-30 22:13:23 UTC) #2
martiniss
(tested locally and it fixes the problem)
4 years, 5 months ago (2016-06-30 22:13:48 UTC) #3
estaab
lgtm
4 years, 5 months ago (2016-06-30 22:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106333004/1
4 years, 5 months ago (2016-06-30 22:36:35 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 22:38:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/97de2622765bdf58b51b827f9e9ba07b19e...

Powered by Google App Engine
This is Rietveld 408576698