Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2106313004: Add browser_test_runner flag for debugging shards' test distributions. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
CC:
catapult-reviews_chromium.org, nednguyen, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add browser_test_runner flag for debugging shards' test distributions. Will be useful for experimentation with more sharding algorithms. BUG=chromium:352807 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/47a44e3dbbd200d9c25f76c2b13acda6b077ae56

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review feedback from eakuefner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M telemetry/telemetry/testing/browser_test_runner.py View 1 5 chunks +38 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ken Russell (switch to Gerrit)
Kari or Ethan: please review. Thanks. Ned: FYI. We'll want this for debugging.
4 years, 5 months ago (2016-07-01 00:09:44 UTC) #2
eakuefner
lgtm https://codereview.chromium.org/2106313004/diff/1/telemetry/telemetry/testing/browser_test_runner.py File telemetry/telemetry/testing/browser_test_runner.py (right): https://codereview.chromium.org/2106313004/diff/1/telemetry/telemetry/testing/browser_test_runner.py#newcode98 telemetry/telemetry/testing/browser_test_runner.py:98: for i in xrange(len(shards)): nit: you can write ...
4 years, 5 months ago (2016-07-01 17:05:36 UTC) #3
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2106313004/diff/1/telemetry/telemetry/testing/browser_test_runner.py File telemetry/telemetry/testing/browser_test_runner.py (right): https://codereview.chromium.org/2106313004/diff/1/telemetry/telemetry/testing/browser_test_runner.py#newcode98 telemetry/telemetry/testing/browser_test_runner.py:98: for i in xrange(len(shards)): On 2016/07/01 17:05:36, eakuefner wrote: ...
4 years, 5 months ago (2016-07-01 23:38:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106313004/20001
4 years, 5 months ago (2016-07-01 23:38:08 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 00:02:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698