Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2106253002: [MD Settings] Show '(copied to Chrome)' on credit cards that are local. (Closed)

Created:
4 years, 5 months ago by hcarmona
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] Show '(copied to Chrome)' on credit cards that are local. Swaps Chrome/Chromium where appropriate. Screenshot in bug. BUG=622174 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8329ebd3415322e33fe38fd5564cc040105b9a10 Cr-Commit-Position: refs/heads/master@{#403194}

Patch Set 1 #

Total comments: 2

Patch Set 2 : chrome/chromium fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
hcarmona
PTAL, this should wrap up the CC changes to MD settings. Thanks!
4 years, 5 months ago (2016-06-29 22:37:37 UTC) #3
tommycli
https://codereview.chromium.org/2106253002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2106253002/diff/1/chrome/app/settings_strings.grdp#newcode228 chrome/app/settings_strings.grdp:228: Google Payments (copied to Chrome) What's the plan for ...
4 years, 5 months ago (2016-06-29 22:59:34 UTC) #4
hcarmona
https://codereview.chromium.org/2106253002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2106253002/diff/1/chrome/app/settings_strings.grdp#newcode228 chrome/app/settings_strings.grdp:228: Google Payments (copied to Chrome) On 2016/06/29 22:59:34, tommycli ...
4 years, 5 months ago (2016-06-30 00:58:59 UTC) #6
tommycli
lgtm
4 years, 5 months ago (2016-06-30 16:12:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106253002/20001
4 years, 5 months ago (2016-06-30 16:14:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 16:26:24 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 16:26:34 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 16:27:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8329ebd3415322e33fe38fd5564cc040105b9a10
Cr-Commit-Position: refs/heads/master@{#403194}

Powered by Google App Engine
This is Rietveld 408576698