Added gvr-android-sdk to third_party/

Added gvr-android-sdk to third_party/

BUG=389343
Committed: https://crrev.com/c690d9acd621580286df87ce78519ea5ac88a448
Cr-Commit-Position: refs/heads/master@{#410405}

[bajones, 2016-06-30 19:58:58]

bajones@chromium.org changed reviewers:
+ jochen@chromium.org, thakis@chromium.org

[bajones, 2016-06-30 19:58:58]

jochen@ or thakis@: Please take a look.

This library is a newer iteration of the existing cardboard-java, which we're
going to remove once the dependent code has been migrated over.

[Nico, 2016-06-30 20:17:24]

Since this is a new third_party thing, I believe you need legal, security,
eng-review again. Since it's similar to an existing thing, that should probably
be pretty quick.

lgtm with that.

https://codereview.chromium.org/2106243003/diff/1/third_party/gvr-android-sdk...
File third_party/gvr-android-sdk/BUILD.gn (right):

https://codereview.chromium.org/2106243003/diff/1/third_party/gvr-android-sdk...
third_party/gvr-android-sdk/BUILD.gn:17:
"src/ndk-beta/lib/android_arm/libgvr.so",
Is the SDK open-source? If so, can we compile it instead of using the .so?
Benefits of that over binary blobs:
* that code will be instrumented in asan (and other *san) builds
* it's more clear what we link in

[bajones, 2016-06-30 20:19:54]

On 2016/06/30 20:17:24, Nico wrote:
> Since this is a new third_party thing, I believe you need legal, security,
> eng-review again. Since it's similar to an existing thing, that should
probably
> be pretty quick.

Will do!

> Is the SDK open-source? If so, can we compile it instead of using the .so?
> Benefits of that over binary blobs:
> * that code will be instrumented in asan (and other *san) builds
> * it's more clear what we link in

I would ADORE it if we could get this in an open source form, but that's a
decision for the Daydream team.

[jochen (gone - plz use gerrit), 2016-07-01 14:14:31]

lgtm

[Martin Barbella, 2016-08-08 17:50:14]

mbarbella@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Martin Barbella, 2016-08-08 17:50:15]

lgtm from security

[bajones, 2016-08-08 17:56:15]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-08-08 17:56:16]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2106243003/#ps60001
(title: "Updated to 0.9.0")

[commit-bot: I haz the power, 2016-08-08 17:56:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 19:59:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-08 20:01:49]

Description was changed from

==========
Added gvr-android-sdk to third_party/

BUG=389343
==========

to

==========
Added gvr-android-sdk to third_party/

BUG=389343

Committed: https://crrev.com/c690d9acd621580286df87ce78519ea5ac88a448
Cr-Commit-Position: refs/heads/master@{#410405}
==========

[commit-bot: I haz the power, 2016-08-08 20:01:50]

Patchset 4 (id:??) landed as
https://crrev.com/c690d9acd621580286df87ce78519ea5ac88a448
Cr-Commit-Position: refs/heads/master@{#410405}