Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 210623003: [VideoPlayer] Remove the old video player from Files.app (Closed)

Created:
6 years, 9 months ago by yoshiki
Modified:
6 years, 9 months ago
Reviewers:
hirono, hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[VideoPlayer] Remove the old video player from Files.app Since the dedicated video player app has been added (crrev.com/259070), we remove the old one which is embedded in Files.app. BUG=271811 TEST=manually tested TBR=asargent@chromium.org # TBRing for adding a resource and changing the order of component extension loads. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259219

Patch Set 1 #

Total comments: 6

Patch Set 2 : Adressed the comments #

Total comments: 2

Patch Set 3 : Adressed the comments #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -647 lines) Patch
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/background/js/background.js View 3 chunks +0 lines, -22 lines 0 comments Download
D chrome/browser/resources/file_manager/foreground/css/video_player.css View 1 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_tasks.js View 3 chunks +0 lines, -15 lines 0 comments Download
D chrome/browser/resources/file_manager/foreground/js/media/video_player.js View 1 chunk +0 lines, -289 lines 0 comments Download
D chrome/browser/resources/file_manager/foreground/js/media/video_player_scripts.js View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/resources/file_manager/manifest.json View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/resources/file_manager/video_player.html View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/browser/resources/video_player/manifest.json View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js View 1 3 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yoshiki
@hashimoto, @hirono, could you take a look? Thanks.
6 years, 9 months ago (2014-03-25 07:12:49 UTC) #1
hashimoto
https://codereview.chromium.org/210623003/diff/20001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (left): https://codereview.chromium.org/210623003/diff/20001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#oldcode730 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:730: ::testing::Values(TestParameter(IN_GUEST_MODE, "videoOpenDownloads"), "videoOpenDownloads" and other strings are corresponding to ...
6 years, 9 months ago (2014-03-25 07:25:19 UTC) #2
hirono
lgtm with a nit! https://codereview.chromium.org/210623003/diff/20001/chrome/browser/resources/file_manager/video_player.html File chrome/browser/resources/file_manager/video_player.html (left): https://codereview.chromium.org/210623003/diff/20001/chrome/browser/resources/file_manager/video_player.html#oldcode15 chrome/browser/resources/file_manager/video_player.html:15: <link rel="stylesheet" type="text/css" href="foreground/css/video_player.css"> Can ...
6 years, 9 months ago (2014-03-25 07:37:26 UTC) #3
yoshiki
https://codereview.chromium.org/210623003/diff/20001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (left): https://codereview.chromium.org/210623003/diff/20001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#oldcode730 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:730: ::testing::Values(TestParameter(IN_GUEST_MODE, "videoOpenDownloads"), On 2014/03/25 07:25:19, hashimoto wrote: > "videoOpenDownloads" ...
6 years, 9 months ago (2014-03-25 07:45:45 UTC) #4
hashimoto
lgtm https://codereview.chromium.org/210623003/diff/60001/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/210623003/diff/60001/chrome/browser/extensions/component_loader.cc#newcode442 chrome/browser/extensions/component_loader.cc:442: // Component extensions needed for kiosk apps. nit: ...
6 years, 9 months ago (2014-03-25 07:47:36 UTC) #5
yoshiki
Thanks! https://codereview.chromium.org/210623003/diff/60001/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/210623003/diff/60001/chrome/browser/extensions/component_loader.cc#newcode442 chrome/browser/extensions/component_loader.cc:442: // Component extensions needed for kiosk apps. On ...
6 years, 9 months ago (2014-03-25 08:36:46 UTC) #6
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 9 months ago (2014-03-25 08:36:50 UTC) #7
yoshiki
The CQ bit was unchecked by yoshiki@chromium.org
6 years, 9 months ago (2014-03-25 08:36:52 UTC) #8
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 9 months ago (2014-03-25 08:38:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/210623003/90001
6 years, 9 months ago (2014-03-25 08:39:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/210623003/90001
6 years, 9 months ago (2014-03-25 12:52:24 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 16:04:58 UTC) #12
Message was sent while issue was closed. 
Change committed as 259219

Powered by Google App Engine
This is Rietveld 408576698