Switch to VS 2015 Update 3

Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2 (en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1: 247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July 12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.14393.0

BUG=627216, 636468, 427616, 637456
Committed: https://crrev.com/02343c661ee0482cb73ad0cf861999f2c57eeb11
Cr-Commit-Position: refs/heads/master@{#417157}

[brucedawson, 2016-06-29 18:48:16]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as blah, foo, and
bar.

It also fixes an internal compiler error in /analyze builds.

BUG=440500
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance.

It also fixes an internal compiler error in /analyze builds.

BUG=440500
==========

[brucedawson, 2016-08-11 23:17:45]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-08-11 23:57:52]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance.

It also fixes an internal compiler error in /analyze builds.

BUG=440500
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Universal Windows App Development Tools and make sure the “Tools (1.4.1) and
Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

[commit-bot: I haz the power, 2016-08-12 00:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:03:49]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[brucedawson, 2016-08-12 00:49:23]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Universal Windows App Development Tools and make sure the “Tools (1.4.1) and
Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

[brucedawson, 2016-08-18 17:25:22]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:25:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:19:27]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2016-08-19 17:36:31]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 17:37:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-08-19 17:39:53]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

[brucedawson, 2016-08-19 17:43:27]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

[brucedawson, 2016-08-19 17:46:07]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

The -Wno-extern-initializer flag is needed for clang compatibility with the
latest midl compiler - see bug 637456

BUG=627216,636468,427616,637456
==========

[commit-bot: I haz the power, 2016-08-19 19:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:50:09]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brucedawson, 2016-08-19 20:50:01]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 20:50:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:00:19]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-08-19 23:31:01]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 23:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:40:35]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brucedawson, 2016-08-20 01:27:27]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the “Tools (1.4.1)
and Windows 10 SDK (10.0.14393) and the “Windows 10 SDK (10.0.10586)” nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

The -Wno-extern-initializer flag is needed for clang compatibility with the
latest midl compiler - see bug 637456

BUG=627216,636468,427616,637456
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

The -Wno-extern-initializer flag is needed for clang compatibility with the
latest midl compiler - see bug 637456

BUG=627216,636468,427616,637456
==========

[brucedawson, 2016-08-22 19:58:53]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 19:59:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:54:30]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2016-08-24 18:44:46]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 18:45:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:48:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2016-08-27 00:10:38]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 00:11:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-08-27 00:21:32]

On 2016/08/27 00:11:48, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

On 2016/08/24 21:48:54, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Back to looking at the failures. The relevant error message is this:

Problem when trying to gather stack trace: Command
'['E:\\b\\swarm_slave\\w\\ir70jm7o\\out\\Release_x64\\cdb\\cdb.exe', '-y',
'E:\\b\\swarm_slave\\w\\ir70jm7o\\out\\Release_x64', '-c',
'.ecxr;kb30;~*kb30;q', '-z',
'e:\\b\\swarm_slave\\w\\itj5fv6o\\tmpero_hg\\reports\\27fa0f0a-78ca-41d9-af2b-e0fdd0577c5d.dmp']'
returned non-zero exit status -1073741515

Error code -1073741515 is equal to 0xC0000135 which is "The application failed
to intialize properly". I can't see any flags set in the binary that would
explain why it fails to launch, and cdb.exe runs fine on a Windows Server 2012
R2 GCE VM, but that comes with the universal Windows 10 runtime preinstalled.
So, the new update to the patch copies api-ms-win-*.dll to the cdb directory,
which should probably have been done anyway. Try job running...

[commit-bot: I haz the power, 2016-08-27 01:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:51:44]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[brucedawson, 2016-08-29 21:49:12]

At first I thought that my copying of the Windows 10 Universal CRT DLLs had made
no difference, but that was wrong.

The failure code used to be -1073741515 (0xC0000135)
Now the failure code is -1073741511 (0xC0000139)

If that's not progress then I don't know what is. That's four better!

0xC0000139 seems to be DLL not found or entry point not found:
http://stackoverflow.com/questions/795391/loadlibrary-fails-first-chance-exce...

This suggests that the process was created and then maybe it failed when calling
LoadLibrary, or ???

[brucedawson, 2016-09-02 01:14:45]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 03:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 03:32:46]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-09-02 15:54:01]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking failing.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

The -Wno-extern-initializer flag is needed for clang compatibility with the
latest midl compiler - see bug 637456

BUG=627216,636468,427616,637456
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456
==========

[brucedawson, 2016-09-02 20:37:50]

Test failures were caused by missing out\<outdir>\cdb\ucrtbase.dll, now fixed.

I'm now investigating an Update 3 ICE in skia as the next (last?) possible
blocker.

[brucedawson, 2016-09-02 21:36:48]

ICE is being resolved in crrev.com/2308833002

[brucedawson, 2016-09-02 21:38:52]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 21:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:42:45]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-09-02 22:30:29]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456
==========

[brucedawson, 2016-09-02 22:30:30]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org, sullivan@chromium.org

[brucedawson, 2016-09-03 05:53:04]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 05:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-03 06:29:36]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2016-09-06 18:42:19]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:42:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-06 18:44:12]

The CQ bit was unchecked by brucedawson@chromium.org

[scottmg, 2016-09-06 19:02:41]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-09-06 19:02:45]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2016-09-06 19:03:13]

lgtm

[sullivan, 2016-09-07 14:34:13]

sullivan@chromium.org changed reviewers:
+ dtu@chromium.org

[sullivan, 2016-09-07 14:34:13]

Sorry I'm a little groggy, just got back from vacation, but I'm not clear on why
I'm added as a reviewer.

* If it's potential breakages to perf or bisect builds, +dtu can take a look
* If it's possible performance changes, please add a note in the CL description
to perf sheriffs

Otherwise, just let me know how I can help!

[brucedawson, 2016-09-07 20:46:06]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:53:20]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456
==========

[commit-bot: I haz the power, 2016-09-08 01:53:22]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-09-08 01:54:58]

Description was changed from

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456
==========

to

==========
Switch to VS 2015 Update 3

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2
(en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1:
247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July
12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1)
and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are
selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run
them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w
10.0.14393.0

BUG=627216,636468,427616,637456

Committed: https://crrev.com/02343c661ee0482cb73ad0cf861999f2c57eeb11
Cr-Commit-Position: refs/heads/master@{#417157}
==========

[commit-bot: I haz the power, 2016-09-08 01:54:59]

Patchset 10 (id:??) landed as
https://crrev.com/02343c661ee0482cb73ad0cf861999f2c57eeb11
Cr-Commit-Position: refs/heads/master@{#417157}