Issue 21062004: Revert 15940: "Compilation type and state allocate an unnecessary Smi on v8::Script."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21062004: Revert 15940: "Compilation type and state allocate an unnecessary Smi on v8::Script." (Closed)

Created:
7 years, 4 months ago by danno

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert 15940: "Compilation type and state allocate an unnecessary Smi on v8::Script." Due to Mozilla test failures on Win32 debug TBR=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15957

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -54 lines)			Patch
M	src/accessors.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/compiler.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/isolate.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/liveedit.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/objects.h	View	3 chunks	+11 lines, -21 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+2 lines, -19 lines	0 comments	Download
M	src/objects-printer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

danno

Committed patchset #1 manually as r15957 (presubmit successful).

7 years, 4 months ago (2013-07-30 11:24:20 UTC) #2

Message was sent while issue was closed.

LGTM (rubber-stamped).