[Android] Create buildable browser_tests gn target for android.

[Android] Create buildable browser_tests gn target for android.

The target currently contains no tests, but it builds and can successfully
report itself as empty w/ --gtest_list_tests.

This should be a no-op for non-Android platforms.

BUG=611756
Committed: https://crrev.com/05f3312145a23913441d0e1a0f228fd349ae8f9f
Cr-Commit-Position: refs/heads/master@{#404179}

[jbudorick, 2016-06-29 16:10:13]

Description was changed from

==========
[Android] Create buildable browser_tests gn target for android.

BUG=611756
==========

to

==========
[Android] Create buildable browser_tests gn target for android.

The target currently contains no tests, but it builds and can successfully
report itself as empty w/ --gtest_list_tests.

BUG=611756
==========

[jbudorick, 2016-06-29 16:10:42]

Description was changed from

==========
[Android] Create buildable browser_tests gn target for android.

The target currently contains no tests, but it builds and can successfully
report itself as empty w/ --gtest_list_tests.

BUG=611756
==========

to

==========
[Android] Create buildable browser_tests gn target for android.

The target currently contains no tests, but it builds and can successfully
report itself as empty w/ --gtest_list_tests.

This should be a no-op for non-Android platforms.

BUG=611756
==========

[jbudorick, 2016-07-01 19:01:34]

jbudorick@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, sky@chromium.org

[Paweł Hajdan Jr., 2016-07-05 09:29:54]

Rubber stamp LGTM (diff for GN is really hard to read)

[sky, 2016-07-06 16:00:52]

https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:46: 'chrome_browser_tests_sources': [
Please add a comment as to why this is empty. Anyone casually looking at this
file may be inclined to remove the section without realizing somethings are
going to move to it.

https://codereview.chromium.org/2106193002/diff/80001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (left):

https://codereview.chromium.org/2106193002/diff/80001/chrome/test/BUILD.gn#ol...
chrome/test/BUILD.gn:1133: if (is_linux && !is_component_build) {
Can you try to try to keep the same order so this is easier to read (and history
is better preserved)?

[jbudorick, 2016-07-07 14:56:28]

Patchset #7 (id:120001) has been deleted

[jbudorick, 2016-07-07 14:58:33]

https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:46: 'chrome_browser_tests_sources': [
On 2016/07/06 16:00:51, sky wrote:
> Please add a comment as to why this is empty. Anyone casually looking at this
> file may be inclined to remove the section without realizing somethings are
> going to move to it.

Done.

https://codereview.chromium.org/2106193002/diff/80001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (left):

https://codereview.chromium.org/2106193002/diff/80001/chrome/test/BUILD.gn#ol...
chrome/test/BUILD.gn:1133: if (is_linux && !is_component_build) {
On 2016/07/06 16:00:51, sky wrote:
> Can you try to try to keep the same order so this is easier to read (and
history
> is better preserved)?

Done.

[sky, 2016-07-07 17:16:17]

Thanks, LGTM

[jbudorick, 2016-07-07 17:29:23]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-07-07 17:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2106193002/#ps100001
(title: "sky comments")

[commit-bot: I haz the power, 2016-07-07 17:30:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 18:11:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-07 18:11:30]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 18:12:29]

Description was changed from

==========
[Android] Create buildable browser_tests gn target for android.

The target currently contains no tests, but it builds and can successfully
report itself as empty w/ --gtest_list_tests.

This should be a no-op for non-Android platforms.

BUG=611756
==========

to

==========
[Android] Create buildable browser_tests gn target for android.

The target currently contains no tests, but it builds and can successfully
report itself as empty w/ --gtest_list_tests.

This should be a no-op for non-Android platforms.

BUG=611756

Committed: https://crrev.com/05f3312145a23913441d0e1a0f228fd349ae8f9f
Cr-Commit-Position: refs/heads/master@{#404179}
==========

[commit-bot: I haz the power, 2016-07-07 18:12:30]

Patchset 6 (id:??) landed as
https://crrev.com/05f3312145a23913441d0e1a0f228fd349ae8f9f
Cr-Commit-Position: refs/heads/master@{#404179}