Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2106193002: [Android] Create buildable browser_tests gn target for android. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
sky, Paweł Hajdan Jr.
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Create buildable browser_tests gn target for android. The target currently contains no tests, but it builds and can successfully report itself as empty w/ --gtest_list_tests. This should be a no-op for non-Android platforms. BUG=611756 Committed: https://crrev.com/05f3312145a23913441d0e1a0f228fd349ae8f9f Cr-Commit-Position: refs/heads/master@{#404179}

Patch Set 1 #

Patch Set 2 : prereview: back out a currently unnecessary change #

Patch Set 3 : prereview: fix is_chromeos #

Patch Set 4 : prereview: Fix sync linking desktop toolkit_views ordering. #

Patch Set 5 : prereview: Rebase gn fixes. #

Total comments: 4

Patch Set 6 : sky comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -114 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 4 5 2 chunks +9 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 10 chunks +130 lines, -113 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jbudorick
4 years, 5 months ago (2016-07-01 19:01:34 UTC) #4
Paweł Hajdan Jr.
Rubber stamp LGTM (diff for GN is really hard to read)
4 years, 5 months ago (2016-07-05 09:29:54 UTC) #5
sky
https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gypi#newcode46 chrome/chrome_tests.gypi:46: 'chrome_browser_tests_sources': [ Please add a comment as to why ...
4 years, 5 months ago (2016-07-06 16:00:52 UTC) #6
jbudorick
https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/2106193002/diff/80001/chrome/chrome_tests.gypi#newcode46 chrome/chrome_tests.gypi:46: 'chrome_browser_tests_sources': [ On 2016/07/06 16:00:51, sky wrote: > Please ...
4 years, 5 months ago (2016-07-07 14:58:33 UTC) #8
sky
Thanks, LGTM
4 years, 5 months ago (2016-07-07 17:16:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106193002/100001
4 years, 5 months ago (2016-07-07 17:30:33 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-07 18:11:15 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 18:11:30 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:12:30 UTC) #16
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/05f3312145a23913441d0e1a0f228fd349ae8f9f
Cr-Commit-Position: refs/heads/master@{#404179}

Powered by Google App Engine
This is Rietveld 408576698