Port oortonline_tbm to TBMv2.

Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/556cffc13ef8cf71b182e0143f89d2f68c449201
Cr-Commit-Position: refs/heads/master@{#410329}

[ulan, 2016-06-29 13:32:38]

Description was changed from

==========
Port oortonline_tbm to TBMv2.

BUG=621035
==========

to

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[ulan, 2016-06-29 13:34:57]

ulan@chromium.org changed reviewers:
+ petrcermak@chromium.org

[ulan, 2016-06-29 13:34:58]

PTAL.

This CL depends on https://codereview.chromium.org/2104303002/.

[petrcermak, 2016-06-29 14:48:18]

LGTM on the memory stuff (don't know the other stuff) with one comment.

Thanks,
Petr

https://codereview.chromium.org/2106133002/diff/20001/tools/perf/benchmarks/o...
File tools/perf/benchmarks/oortonline.py (right):

https://codereview.chromium.org/2106133002/diff/20001/tools/perf/benchmarks/o...
tools/perf/benchmarks/oortonline.py:77: v8_categories = [
does it still make sense to write the categories like this? I think that the
following would be more readable:

categories = [
  # Implicitly disable all categories.
  '-*',

  # V8.
  'blink.console',
  'disabled-by-default-v8.gc',
  ...

  # Smoothness.
  ...

  # Memory.
  ...
]

[ulan, 2016-06-29 15:38:21]

Thanks!

https://codereview.chromium.org/2106133002/diff/20001/tools/perf/benchmarks/o...
File tools/perf/benchmarks/oortonline.py (right):

https://codereview.chromium.org/2106133002/diff/20001/tools/perf/benchmarks/o...
tools/perf/benchmarks/oortonline.py:77: v8_categories = [
On 2016/06/29 14:48:18, petrcermak wrote:
> does it still make sense to write the categories like this? I think that the
> following would be more readable:
> 
> categories = [
>   # Implicitly disable all categories.
>   '-*',
> 
>   # V8.
>   'blink.console',
>   'disabled-by-default-v8.gc',
>   ...
> 
>   # Smoothness.
>   ...
> 
>   # Memory.
>   ...
> ]

Done.

[ulan, 2016-07-07 11:46:18]

I rebased it to use multiple metrics.

[petrcermak, 2016-07-07 12:56:21]

petrcermak@chromium.org changed reviewers:
+ sullivan@chromium.org

[petrcermak, 2016-07-07 12:56:22]

LGTM.

Annie: Can we please get an owner stamp?

Thanks,
Petr

[petrcermak, 2016-07-07 12:58:42]

(Note: Once again, my LGTM is only for the memory-related stuff. I don't know
the rest).

[sullivan, 2016-07-08 21:16:08]

sullivan@chromium.org changed reviewers:
+ eakuefner@chromium.org

[sullivan, 2016-07-08 21:16:09]

Adding Ethan who is in the office this week and more knowledgeable in TBM2 than
I

[eakuefner, 2016-07-11 15:25:36]

On 2016/07/08 at 21:16:09, sullivan wrote:
> Adding Ethan who is in the office this week and more knowledgeable in TBM2
than I

lgtm as long as we agree that current responsiveness metric will be comparable
to smoothness for this application, and as long as ulan is happy.

[petrcermak, 2016-07-19 09:37:56]

ping

[ulan, 2016-07-19 09:52:27]

On 2016/07/19 09:37:56, petrcermak wrote:
> ping

waiting for https://github.com/catapult-project/catapult/issues/2446

[ulan, 2016-08-01 12:29:09]

Description was changed from

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[ulan, 2016-08-03 09:53:01]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-08-03 09:53:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2106133002/#ps100001
(title: "fix filter")

[commit-bot: I haz the power, 2016-08-03 09:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 09:53:10]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.perf
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-08-03 09:53:12]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-08-03 10:01:15]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-08-03 10:31:20]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[petrcermak, 2016-08-03 10:39:59]

Description was changed from

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[petrcermak, 2016-08-03 10:40:26]

On 2016/08/03 10:31:20, commit-bot: I haz the power wrote:
> There were warnings when CQ was processing your CL:
>  * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
> CQ_INCLUDE_TRYBOTS instead.

I took the liberty of removing CQ_EXTRA_TRYBOTS from the patch description to
avoid this warning.

Petr

[commit-bot: I haz the power, 2016-08-03 11:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 11:53:39]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)
  linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[petrcermak, 2016-08-03 12:11:56]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-03 12:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-08-03 12:12:05]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-03 12:12:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 14:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 14:12:58]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)

[ulan, 2016-08-05 10:20:14]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-08-05 10:20:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 11:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:21:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[petrcermak, 2016-08-05 11:27:47]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 12:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 12:20:55]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)

[petrcermak, 2016-08-05 12:44:37]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-05 12:45:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 14:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 14:45:53]

Exceeded global retry quota

[petrcermak, 2016-08-05 14:48:29]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-05 14:48:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 15:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 15:02:20]

Try jobs failed on following builders:
  winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)

[petrcermak, 2016-08-08 09:23:54]

Description was changed from

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-08-08 09:24:07]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-08 09:24:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 11:29:28]

Description was changed from

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-08-08 11:29:29]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-08 11:31:19]

Description was changed from

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Port oortonline_tbm to TBMv2.

BUG=621035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/556cffc13ef8cf71b182e0143f89d2f68c449201
Cr-Commit-Position: refs/heads/master@{#410329}
==========

[commit-bot: I haz the power, 2016-08-08 11:31:21]

Patchset 6 (id:??) landed as
https://crrev.com/556cffc13ef8cf71b182e0143f89d2f68c449201
Cr-Commit-Position: refs/heads/master@{#410329}