Fixed issue with pods flying when changing profiles.

Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9ceebdcdfadd22c9d2e031cc9d8634c1261907ef
Cr-Commit-Position: refs/heads/master@{#403013}

[sammiequon, 2016-06-29 19:43:44]

Description was changed from

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
==========

to

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-06-29 19:44:37]

Description was changed from

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-06-29 19:44:38]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org, xiyuan@chromium.org

[sammiequon, 2016-06-29 19:44:58]

jdufault@, xiyuan@, Please take a look.

[jdufault, 2016-06-29 20:40:35]

https://codereview.chromium.org/2106113003/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2106113003/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1128:
this.classList.toggle('flying-pin-pod', enable);
Do we ever want this not enabled?

[sammiequon, 2016-06-29 21:01:23]

https://codereview.chromium.org/2106113003/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2106113003/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1128:
this.classList.toggle('flying-pin-pod', enable);
On 2016/06/29 20:40:35, jdufault wrote:
> Do we ever want this not enabled?

It seems the user picker in chrome uses user pod template as well, and the added
transitions for the PIN movement caused the bug. So we only want to toggle this
when we know its the lock screen PIN.

[jdufault, 2016-06-29 21:10:23]

lgtm after rename

https://codereview.chromium.org/2106113003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/lock.js (right):

https://codereview.chromium.org/2106113003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/lock.js:32:
podRow.setEnablePodTransitions(true);
rename to togglePinTransitions

[sammiequon, 2016-06-29 21:34:04]

https://codereview.chromium.org/2106113003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/lock.js (right):

https://codereview.chromium.org/2106113003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/lock.js:32:
podRow.setEnablePodTransitions(true);
On 2016/06/29 21:10:23, jdufault wrote:
> rename to togglePinTransitions

Done.

[jdufault, 2016-06-29 21:34:57]

lgtm

[xiyuan, 2016-06-29 21:50:18]

lgtm

[sammiequon, 2016-06-29 23:05:06]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:05:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:52:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2016-06-29 23:56:07]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:57:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:17:05]

Description was changed from

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-30 00:17:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 00:17:41]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 00:18:58]

Description was changed from

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fixed issue with pods flying when changing profiles.

BUG=623917
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9ceebdcdfadd22c9d2e031cc9d8634c1261907ef
Cr-Commit-Position: refs/heads/master@{#403013}
==========

[commit-bot: I haz the power, 2016-06-30 00:18:59]

Patchset 2 (id:??) landed as
https://crrev.com/9ceebdcdfadd22c9d2e031cc9d8634c1261907ef
Cr-Commit-Position: refs/heads/master@{#403013}