src/profiler/tick-sample.cc - Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/tick-sample.cc

Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/profiler/tick-sample.cc

diff --git a/src/profiler/tick-sample.cc b/src/profiler/tick-sample.cc

index afc2407d5ef7176a20bd9c18ed995652d8233cb6..2595404c13a08070208ec2be8b8c024ba1436b1a 100644

--- a/src/profiler/tick-sample.cc

+++ b/src/profiler/tick-sample.cc

@@ -147,8 +147,7 @@

reinterpret_cast<Address>(regs.sp), js_entry_sp);

size_t i = 0;

if (record_c_entry_frame == kIncludeCEntryFrame && !it.done() &&

- (it.top_frame_type() == StackFrame::EXIT ||

- it.top_frame_type() == StackFrame::BUILTIN_EXIT)) {

+ it.top_frame_type() == StackFrame::EXIT) {

frames[i++] = isolate->c_function();

}

while (!it.done() && i < frames_limit) {

« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »