Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: src/frames.h

Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/external-reference-table.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index cb786202dff880152f419bbe754b5503e9e476a6..a1e438c6943494684ced2512f82f4ea78f598cfe 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -112,8 +112,7 @@
V(INTERNAL, InternalFrame) \
V(CONSTRUCT, ConstructFrame) \
V(ARGUMENTS_ADAPTOR, ArgumentsAdaptorFrame) \
- V(BUILTIN, BuiltinFrame) \
- V(BUILTIN_EXIT, BuiltinExitFrame)
+ V(BUILTIN, BuiltinFrame)
// Every pointer in a frame has a slot id. On 32-bit platforms, doubles consume
// two slots.
@@ -324,12 +323,6 @@
DEFINE_TYPED_FRAME_SIZES(3);
};
-// Behaves like an exit frame but with target and new target args.
-class BuiltinExitFrameConstants : public CommonFrameConstants {
- public:
- static const int kNewTargetOffset = kCallerPCOffset + 1 * kPointerSize;
- static const int kTargetOffset = kNewTargetOffset + 1 * kPointerSize;
-};
class InterpreterFrameConstants : public AllStatic {
public:
@@ -433,7 +426,6 @@
return type() == STUB_FAILURE_TRAMPOLINE;
}
bool is_construct() const { return type() == CONSTRUCT; }
- bool is_builtin_exit() const { return type() == BUILTIN_EXIT; }
virtual bool is_standard() const { return false; }
bool is_java_script() const {
@@ -638,7 +630,6 @@
// iterator and the frames following entry frames.
static Type GetStateForFramePointer(Address fp, State* state);
static Address ComputeStackPointer(Address fp);
- static StackFrame::Type ComputeFrameType(Address fp);
static void FillState(Address fp, Address sp, State* state);
protected:
@@ -648,29 +639,6 @@
private:
void ComputeCallerState(State* state) const override;
-
- friend class StackFrameIteratorBase;
-};
-
-// Builtin exit frames are a special case of exit frames, which are used
-// whenever C++ builtins (e.g., Math.acos) are called. Their main purpose is
-// to allow such builtins to appear in stack traces.
-class BuiltinExitFrame : public ExitFrame {
- public:
- Type type() const override { return BUILTIN_EXIT; }
-
- static BuiltinExitFrame* cast(StackFrame* frame) {
- DCHECK(frame->is_builtin_exit());
- return static_cast<BuiltinExitFrame*>(frame);
- }
-
- virtual JSFunction* function() const;
-
- protected:
- inline explicit BuiltinExitFrame(StackFrameIteratorBase* iterator);
-
- private:
- inline Object* function_slot_object() const;
friend class StackFrameIteratorBase;
};
« no previous file with comments | « src/external-reference-table.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698