Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Side by Side Diff: test/mjsunit/regress/regress-4815.js

Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/message/paren_in_arg_string.out ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var thrower = { [Symbol.toPrimitive]: () => FAIL }; 5 var thrower = { [Symbol.toPrimitive]: () => FAIL };
6 6
7 // Tests that a native conversion function is included in the 7 // Tests that a native conversion function is included in the
8 // stack trace. 8 // stack trace.
9 function testTraceNativeConversion(nativeFunc) { 9 function testTraceNativeConversion(nativeFunc) {
10 var nativeFuncName = nativeFunc.name; 10 var nativeFuncName = nativeFunc.name;
11 try { 11 try {
12 nativeFunc(thrower); 12 nativeFunc(thrower);
13 assertUnreachable(nativeFuncName); 13 assertUnreachable(nativeFuncName);
14 } catch (e) { 14 } catch (e) {
15 assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName); 15 assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName);
16 } 16 }
17 } 17 }
18 18
19 testTraceNativeConversion(Math.max); 19 testTraceNativeConversion(Math.max);
20 testTraceNativeConversion(Math.min); 20 testTraceNativeConversion(Math.min);
21 21
22 // C++ builtins. 22 function testBuiltinInStackTrace(script, nativeFuncName) {
23 testTraceNativeConversion(Math.acos);
24 testTraceNativeConversion(Math.asin);
25 testTraceNativeConversion(Math.fround);
26 testTraceNativeConversion(Math.imul);
27
28
29 function testBuiltinInStackTrace(script, expectedString) {
30 try { 23 try {
31 eval(script); 24 eval(script);
32 assertUnreachable(expectedString); 25 assertUnreachable(nativeFuncName);
33 } catch (e) { 26 } catch (e) {
34 assertTrue(e.stack.indexOf(expectedString) >= 0, expectedString); 27 assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName);
35 } 28 }
36 } 29 }
37 30
38 // Use the full name ('String.getDate') in order to avoid false pass 31 // Use the full name ('String.getDate') in order to avoid false pass
39 // results when the method name is mentioned in the error message itself. 32 // results when the method name is mentioned in the error message itself.
40 // This occurs, e.g., for Date.prototype.getYear, which uses a different code 33 // This occurs, e.g., for Date.prototype.getYear, which uses a different code
41 // path and never hits the Generate_DatePrototype_GetField builtin. 34 // path and never hits the Generate_DatePrototype_GetField builtin.
42 testBuiltinInStackTrace("Date.prototype.getDate.call('')", "at String.getDate"); 35 testBuiltinInStackTrace("Date.prototype.getDate.call('')", "String.getDate");
43 testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')", 36 testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')",
44 "at String.getUTCDate"); 37 "String.getUTCDate");
45 testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime"); 38 testBuiltinInStackTrace("Date.prototype.getTime.call('')", "String.getTime");
46
47 // C++ builtins.
48 testBuiltinInStackTrace("Boolean.prototype.toString.call(thrower);",
49 "at toString");
50 testBuiltinInStackTrace("new Date(thrower);", "at Date");
OLDNEW
« no previous file with comments | « test/message/paren_in_arg_string.out ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698