Revert of [builtins] New frame type for exits to C++ builtins

src/isolate.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/isolate.h"
 
 #include <stdlib.h>
 
 #include <fstream>  // NOLINT(readability/streams)
 #include <sstream>
@@ skipping 408 matching lines @@
             }
           }
           elements->set(cursor++, *recv);
           elements->set(cursor++, *fun);
           elements->set(cursor++, *abstract_code);
           elements->set(cursor++, *offset);
           frames_seen++;
         }
       } break;
 
-      case StackFrame::BUILTIN_EXIT: {
-        BuiltinExitFrame* exit_frame = BuiltinExitFrame::cast(frame);
-        Handle<JSFunction> fun = handle(exit_frame->function(), this);
-        Handle<Code> code = handle(exit_frame->LookupCode(), this);
-        int offset =
-            static_cast<int>(exit_frame->pc() - code->instruction_start());
-
-        // For now, builtin exit frames do not pass along a receiver.
-        elements = MaybeGrow(this, elements, cursor, cursor + 4);
-        elements->set(cursor++, *factory()->undefined_value());
-        elements->set(cursor++, *fun);
-        elements->set(cursor++, *code);
-        elements->set(cursor++, Smi::FromInt(offset));
-        frames_seen++;
-      } break;
-
       case StackFrame::WASM: {
         WasmFrame* wasm_frame = WasmFrame::cast(frame);
         Code* code = wasm_frame->unchecked_code();
         Handle<AbstractCode> abstract_code =
             Handle<AbstractCode>(AbstractCode::cast(code));
         int offset =
             static_cast<int>(wasm_frame->pc() - code->instruction_start());
         elements = MaybeGrow(this, elements, cursor, cursor + 4);
         elements->set(cursor++, wasm_frame->wasm_obj());
         elements->set(cursor++, Smi::FromInt(wasm_frame->function_index()));
@@ skipping 155 matching lines @@
     }
 
     if (!constructor_key_.is_null()) {
       Handle<Object> is_constructor_obj = factory()->ToBoolean(is_constructor);
       JSObject::AddProperty(stack_frame, constructor_key_, is_constructor_obj,
                             NONE);
     }
     return stack_frame;
   }
 
-  Handle<JSObject> NewStackFrameObject(BuiltinExitFrame* frame) {
-    Handle<JSObject> stack_frame =
-        factory()->NewJSObject(isolate_->object_function());
-    Handle<JSFunction> fun = handle(frame->function(), isolate_);
-    if (!function_key_.is_null()) {
-      Handle<Object> fun_name = JSFunction::GetDebugName(fun);
-      JSObject::AddProperty(stack_frame, function_key_, fun_name, NONE);
-    }
-
-    // We don't have a script and hence cannot set line and col positions.
-    DCHECK(!fun->shared()->script()->IsScript());
-
-    return stack_frame;
-  }
-
   Handle<JSObject> NewStackFrameObject(WasmFrame* frame) {
     Handle<JSObject> stack_frame =
         factory()->NewJSObject(isolate_->object_function());
 
     if (!function_key_.is_null()) {
       Handle<String> name = wasm::GetWasmFunctionName(
           isolate_, handle(frame->wasm_obj(), isolate_),
           frame->function_index());
       JSObject::AddProperty(stack_frame, function_key_, name, NONE);
     }
@@ skipping 108 matching lines @@
         Handle<JSFunction> fun = frames[i].function();
         // Filter frames from other security contexts.
         if (!(options & StackTrace::kExposeFramesAcrossSecurityOrigins) &&
             !this->context()->HasSameSecurityTokenAs(fun->context()))
           continue;
         Handle<JSObject> new_frame_obj = helper.NewStackFrameObject(frames[i]);
         stack_trace_elems->set(frames_seen, *new_frame_obj);
         frames_seen++;
       }
     } else {
-      DCHECK(frame->is_wasm());
       WasmFrame* wasm_frame = WasmFrame::cast(frame);
       Handle<JSObject> new_frame_obj = helper.NewStackFrameObject(wasm_frame);
       stack_trace_elems->set(frames_seen, *new_frame_obj);
       frames_seen++;
     }
   }
 
   stack_trace->set_length(Smi::FromInt(frames_seen));
   return stack_trace;
 }
@@ skipping 2300 matching lines @@
   // Then check whether this scope intercepts.
   if ((flag & intercept_mask_)) {
     intercepted_flags_ |= flag;
     return true;
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace v8