Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
11 #include "src/runtime/runtime.h" 11 #include "src/runtime/runtime.h"
12 12
13 namespace v8 { 13 namespace v8 {
14 namespace internal { 14 namespace internal {
15 15
16 16
17 #define __ ACCESS_MASM(masm) 17 #define __ ACCESS_MASM(masm)
18 18
19 void Builtins::Generate_Adaptor(MacroAssembler* masm, CFunctionId id, 19 void Builtins::Generate_Adaptor(MacroAssembler* masm, CFunctionId id) {
20 ExitFrameType exit_frame_type) {
21 // ----------- S t a t e ------------- 20 // ----------- S t a t e -------------
22 // -- r0 : number of arguments excluding receiver 21 // -- r0 : number of arguments excluding receiver
23 // -- r1 : target 22 // -- r1 : target
24 // -- r3 : new.target 23 // -- r3 : new.target
25 // -- sp[0] : last argument 24 // -- sp[0] : last argument
26 // -- ... 25 // -- ...
27 // -- sp[4 * (argc - 1)] : first argument 26 // -- sp[4 * (argc - 1)] : first argument
28 // -- sp[4 * argc] : receiver 27 // -- sp[4 * argc] : receiver
29 // ----------------------------------- 28 // -----------------------------------
30 __ AssertFunction(r1); 29 __ AssertFunction(r1);
31 30
32 // Make sure we operate in the context of the called function (for example 31 // Make sure we operate in the context of the called function (for example
33 // ConstructStubs implemented in C++ will be run in the context of the caller 32 // ConstructStubs implemented in C++ will be run in the context of the caller
34 // instead of the callee, due to the way that [[Construct]] is defined for 33 // instead of the callee, due to the way that [[Construct]] is defined for
35 // ordinary functions). 34 // ordinary functions).
36 __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset)); 35 __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset));
37 36
38 // Insert extra arguments. 37 // Insert extra arguments.
39 const int num_extra_args = 2; 38 const int num_extra_args = 2;
40 __ Push(r1, r3); 39 __ Push(r1, r3);
41 40
42 // JumpToExternalReference expects r0 to contain the number of arguments 41 // JumpToExternalReference expects r0 to contain the number of arguments
43 // including the receiver and the extra arguments. 42 // including the receiver and the extra arguments.
44 __ add(r0, r0, Operand(num_extra_args + 1)); 43 __ add(r0, r0, Operand(num_extra_args + 1));
45 44
46 __ JumpToExternalReference(ExternalReference(id, masm->isolate()), 45 __ JumpToExternalReference(ExternalReference(id, masm->isolate()));
47 exit_frame_type == BUILTIN_EXIT);
48 } 46 }
49 47
50 48
51 // Load the built-in InternalArray function from the current context. 49 // Load the built-in InternalArray function from the current context.
52 static void GenerateLoadInternalArrayFunction(MacroAssembler* masm, 50 static void GenerateLoadInternalArrayFunction(MacroAssembler* masm,
53 Register result) { 51 Register result) {
54 // Load the InternalArray function from the current native context. 52 // Load the InternalArray function from the current native context.
55 __ LoadNativeContextSlot(Context::INTERNAL_ARRAY_FUNCTION_INDEX, result); 53 __ LoadNativeContextSlot(Context::INTERNAL_ARRAY_FUNCTION_INDEX, result);
56 } 54 }
57 55
(...skipping 2820 matching lines...) Expand 10 before | Expand all | Expand 10 after
2878 } 2876 }
2879 } 2877 }
2880 2878
2881 2879
2882 #undef __ 2880 #undef __
2883 2881
2884 } // namespace internal 2882 } // namespace internal
2885 } // namespace v8 2883 } // namespace v8
2886 2884
2887 #endif // V8_TARGET_ARCH_ARM 2885 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698