Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2106103008: Update dart2js to fix #80. (Closed)

Created:
4 years, 5 months ago by ahe
Modified:
4 years, 5 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com, kustermann
Base URL:
git@github.com:dart-lang/rasta.git@analyze
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Update dart2js to fix #80. BUG=https://github.com/dart-lang/rasta/issues/80 R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/b79320488612cfdcd6d5bc2488a8291438502875

Patch Set 1 #

Patch Set 2 : Mixin application names should be local to libraries. #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M lib/kernel.dart View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M submodules.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/kernel/regression/issue_000080.dart View 1 chunk +10 lines, -1 line 0 comments Download
A test/kernel/regression/issue_000080.dart.txt View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ahe
4 years, 5 months ago (2016-07-01 10:06:59 UTC) #2
kasperl
LGTM. Good to see the regression test case in there.
4 years, 5 months ago (2016-07-01 11:09:18 UTC) #3
ahe
PTAL
4 years, 5 months ago (2016-07-01 11:37:59 UTC) #4
kasperl
LGTM. https://codereview.chromium.org/2106103008/diff/20001/lib/kernel.dart File lib/kernel.dart (right): https://codereview.chromium.org/2106103008/diff/20001/lib/kernel.dart#newcode192 lib/kernel.dart:192: mixinApplicationNames.putIfAbsent(name, () => 0); int count = mixinApplicationNames.putIfAbsent(name, ...
4 years, 5 months ago (2016-07-01 13:05:14 UTC) #5
ahe
Thank you! https://codereview.chromium.org/2106103008/diff/20001/lib/kernel.dart File lib/kernel.dart (right): https://codereview.chromium.org/2106103008/diff/20001/lib/kernel.dart#newcode192 lib/kernel.dart:192: mixinApplicationNames.putIfAbsent(name, () => 0); On 2016/07/01 13:05:14, ...
4 years, 5 months ago (2016-07-01 13:14:15 UTC) #6
ahe
4 years, 5 months ago (2016-07-01 13:15:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b79320488612cfdcd6d5bc2488a8291438502875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698