Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6994)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2106103006: MD Settings: cr/cros - Guest mode page visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase after overscrollHeight_() fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 016b1a81140829ce6b6a0cd3d660808b7fcb5cf0..0d1f2c9cd8d7bb71764067befab331b1bd86bd80 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -22,6 +22,14 @@ Polymer({
notify: true,
observer: 'currentRouteChanged_',
},
+
+ /**
+ * Dictionary defining page visibility.
+ * @type {!GuestModePageVisibility}
+ */
+ pageVisibility: {
+ type: Object,
+ },
},
attached: function() {
@@ -51,6 +59,8 @@ Polymer({
// Sync URL changes to the side nav menu.
if (newRoute.page == 'advanced') {
+ assert(!this.pageVisibility ||
+ this.pageVisibility.advancedSettings !== false);
this.$.advancedMenu.selected = this.currentRoute.section;
this.$.basicMenu.selected = null;
} else if (newRoute.page == 'basic') {

Powered by Google App Engine
This is Rietveld 408576698