MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/languages_page/languages_page.js

Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index f559f593bcecd13f6e323d5979527ba830299ffe..dacba09d17d931b8ec7737572103caa97b3c02f8 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -68,7 +68,7 @@ Polymer({
    */
   onLanguageTap_: function(e) {
     // Only change the UI language on platforms that allow it.
-    if (!cr.isChromeOS && !cr.isWindows)
+    if ((!cr.isChromeOS && !cr.isWindows) || loadTimeData.getBoolean('isGuest'))

[dpapad, 2016/07/22 22:40:48]

Why is this button enabled/visible in cases were it results in a no-op?

[Moe, 2016/07/24 23:54:26]

The language row always remains visible. line 285 prevents it from looking
actionable in guest mode and the tap event is ignored here.

       return;
 
     // Set the prospective UI language. This won't take effect until a restart.
@@ -282,7 +282,7 @@ Polymer({
     var classes = [];
 
     if (cr.isChromeOS || cr.isWindows) {
-      if (supportsUI)
+      if (supportsUI && !loadTimeData.getBoolean('isGuest'))
         classes.push('list-button');  // Makes the item look "actionable".
 
       if (this.isProspectiveUILanguage_(languageCode, prospectiveUILanguage))