MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/advanced_page/advanced_page.html

Index: chrome/browser/resources/settings/advanced_page/advanced_page.html
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html
index f409558f349a8401e052b21f53307e14f1d587f8..d4258fc12d03055f228443061eba93f99c302a47 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html
@@ -31,7 +31,8 @@
       <template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]" restamp>
         <settings-section page-title="$i18n{dateTimePageTitle}"
             current-route="[[currentRoute]]" section="dateTime">
-          <settings-date-time-page prefs="{{prefs}}">
+          <settings-date-time-page prefs="{{prefs}}"
+              page-visibility="[[pageVisibility.dateTime]]">
           </settings-date-time-page>
         </settings-section>
       </template>
@@ -40,7 +41,8 @@
         <settings-section page-title="$i18n{privacyPageTitle}"
             current-route="[[currentRoute]]" section="privacy">
           <settings-privacy-page prefs="{{prefs}}"
-            current-route="{{currentRoute}}">
+              current-route="{{currentRoute}}"
+              page-visibility="[[pageVisibility.privacy]]">

[dpapad, 2016/07/22 18:33:04]

Here you are passing |pageVisibility.privacy| to the privacy page, which is
supposed to be of type
{networkPrediction: boolean, searchPrediction: boolean}, but in
privacy_page.html you are accessing |pageVisibility.privacy.searchPrediction|
which seems incorrect. Shouldn't it simply be |pageVisibility.searchPrediction|
?

[Moe, 2016/07/22 20:53:49]

|pageVisibility.privacy.searchPrediction| is incorrect. thanks for catching it.

           </settings-privacy-page>
         </settings-section>
       </template>
@@ -75,7 +77,8 @@
       <template is="dom-if" if="[[showPage(pageVisibility.downloads)]]" restamp>
         <settings-section page-title="$i18n{downloadsPageTitle}"
             current-route="[[currentRoute]]" section="downloads">
-          <settings-downloads-page prefs="{{prefs}}">
+          <settings-downloads-page prefs="{{prefs}}"
+              page-visibility="[[pageVisibility.downloads]]">
           </settings-downloads-page>
         </settings-section>
       </template>