MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/settings_ui/settings_ui.js

Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index 09ad8f6de7c0162c0b2834fdb4ae1fb8e53a2e7c..2f95a1af0ce857fe9de02a64abbee5d731877d2a 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -66,6 +66,46 @@ Polymer({
     'sideNav.iron-activate': 'onIronActivate_',
   },
 
+  /** @override */
+  ready: function() {
+    this.$$('cr-toolbar').addEventListener('search-changed', function(e) {
+      this.$$('settings-main').searchContents(e.detail);
+    }.bind(this));
+
+    if (loadTimeData.getBoolean('isGuest')) {
+      this.pageVisibility_ = {

[dpapad, 2016/07/21 18:33:33]

Where is this private member var declared? I don't see it in the "properties"
section above. Also please create a typedef for this so that it is properly type
checked.

[Moe, 2016/07/22 16:59:56]

Done.

+        people: false,
+        onStartup: false,
+        reset: false,
+<if expr="not chromeos">
+        appearance: false,
+        defaultBrowser: false,
+
+        hideAdvancedSettings: true,
+</if>
+<if expr="chromeos">
+        appearance: {
+          setWallpaper: false,
+          setTheme: false,
+          homeButton: false,
+          bookmarksBar: false,
+          pageZoom: false,
+        },
+        dateTime: {
+          timeZoneSelector: false,
+        },
+        privacy: {
+          networkPrediction: false,
+        },
+        passwordsAndForms: false,
+        downloads: {
+          googleDrive: false,
+        },
+</if>
+      };
+    }
+  },
+
   /** @private */
   onCloseAppealTap_: function() {
     window.sessionStorage.appealClosed_ = this.appealClosed_ = true;
@@ -85,13 +125,6 @@ Polymer({
     this.$$('app-drawer').toggle();
   },
 
-  /** @override */
-  ready: function() {
-    this.$$('cr-toolbar').addEventListener('search-changed', function(e) {
-      this.$$('settings-main').searchContents(e.detail);
-    }.bind(this));
-  },
-
   /** @private */
   directionDelegateChanged_: function() {
     this.$$('app-drawer').align = this.directionDelegate.isRtl() ?