MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/settings_menu/settings_menu.js

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 016b1a81140829ce6b6a0cd3d660808b7fcb5cf0..845faf4954a0bb44392b70846e2b9495e3ae8926 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -22,6 +22,13 @@ Polymer({
       notify: true,
       observer: 'currentRouteChanged_',
     },
+
+    /**
+     * Dictionary defining page visibility.
+     */
+    pageVisibility: {

[dpapad, 2016/07/21 18:33:33]

This needs an @type annotation (here and elsewhere).

[Moe, 2016/07/22 16:59:56]

according to michaelpg@ type is unnecessary IF we decide not to typedef
pageVisibility. Closure's Polymer pass figures out the type is Object.

+      type: Object,
+    },
   },
 
   attached: function() {
@@ -51,6 +58,9 @@ Polymer({
     // Sync URL changes to the side nav menu.
 
     if (newRoute.page == 'advanced') {
+      var pageVisibility =  /** @type {{hideAdvancedSettings: boolean}} */
+          (this.pageVisibility);
+      assert(!pageVisibility.hideAdvancedSettings);
       this.$.advancedMenu.selected = this.currentRoute.section;
       this.$.basicMenu.selected = null;
     } else if (newRoute.page == 'basic') {