Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 2106103006: MD Settings: cr/cros - Guest mode page visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments + took out cr_element parts Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.html
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html
index f409558f349a8401e052b21f53307e14f1d587f8..660d6b7ccd2ae7006771847186456f4c3c2a8b4d 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html
@@ -31,7 +31,8 @@
<template is="dom-if" if="[[showPage(pageVisibility.dateTime)]]" restamp>
<settings-section page-title="$i18n{dateTimePageTitle}"
current-route="[[currentRoute]]" section="dateTime">
- <settings-date-time-page prefs="{{prefs}}">
+ <settings-date-time-page prefs="{{prefs}}"
+ page-visibility="[[pageVisibility]]">
</settings-date-time-page>
</settings-section>
</template>
@@ -40,7 +41,8 @@
<settings-section page-title="$i18n{privacyPageTitle}"
current-route="[[currentRoute]]" section="privacy">
<settings-privacy-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
+ current-route="{{currentRoute}}"
+ page-visibility="[[pageVisibility]]">
michaelpg 2016/07/21 21:58:44 nit: 4-space indent (the above line was wrong)
Moe 2016/07/22 16:59:56 Done.
</settings-privacy-page>
</settings-section>
</template>
@@ -75,7 +77,8 @@
<template is="dom-if" if="[[showPage(pageVisibility.downloads)]]" restamp>
<settings-section page-title="$i18n{downloadsPageTitle}"
current-route="[[currentRoute]]" section="downloads">
- <settings-downloads-page prefs="{{prefs}}">
+ <settings-downloads-page prefs="{{prefs}}"
+ page-visibility="[[pageVisibility]]">
</settings-downloads-page>
</settings-section>
</template>

Powered by Google App Engine
This is Rietveld 408576698