MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/settings_menu/settings_menu.js

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 016b1a81140829ce6b6a0cd3d660808b7fcb5cf0..81de05935d4f15fb077cdf2536ed83a64eccd54b 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -22,6 +22,15 @@ Polymer({
       notify: true,
       observer: 'currentRouteChanged_',
     },
+
+    /**
+     * Dictionary defining page visibility.
+     * @type {Object}

[michaelpg, 2016/07/21 04:23:03]

type unnecessary -- closure's Polymer pass figures out the type from the
property itself (line 31)

we only have it on line 18 because that's more specific than just Object

[Moe, 2016/07/21 18:27:32]

Done. Thanks for the explanation!

+     */
+    pageVisibility: {
+      type: Object,
+      value: function() { return {}; },

[michaelpg, 2016/07/21 04:23:03]

This shouldn't need a default value here-- set it once (like in settings-main)
and let data binding do the rest. Otherwise we may get some wasteful change
notifications on initialization.

[Moe, 2016/07/21 18:27:32]

Done.

+    },
   },
 
   attached: function() {
@@ -51,6 +60,8 @@ Polymer({
     // Sync URL changes to the side nav menu.
 
     if (newRoute.page == 'advanced') {
+      assert(! /** @type {{hideAdvancedSettings: boolean}} */
+          (this.pageVisibility.hideAdvancedSettings));
       this.$.advancedMenu.selected = this.currentRoute.section;
       this.$.basicMenu.selected = null;
     } else if (newRoute.page == 'basic') {