MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/appearance_page/appearance_page.html

Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index 33a89ab11a5fdaa90211f405df750b281fc835c5..b7b8f23b9e9c882ee424336cbe12ca88b1abb73c 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -29,17 +29,20 @@
       <neon-animatable id="main">
 <if expr="chromeos">
         <div class="settings-box first two-line" id="wallpaperButton"
-            on-tap="openWallpaperManager_" actionable>
+            on-tap="openWallpaperManager_" actionable
+            hidden="[[!pageVisibility.appearance.setWallpaper]]">
           <iron-icon icon="settings:wallpaper"></iron-icon>
           <div class="start">
             <div>$i18n{setWallpaper}</div>
             <div class="secondary">$i18n{openWallpaperApp}</div>
           </div>
         </div>
-        <div class="settings-box two-line">
+        <div class="settings-box two-line"
+            hidden="[[!pageVisibility.appearance.setTheme]]">
 </if>
 <if expr="not chromeos">
-        <div class="settings-box two-line first">
+        <div class="settings-box two-line first"
+            hidden="[[!pageVisibility.appearance.setTheme]]">
 </if>
           <div class="layout horizontal center flex"
               on-tap="openThemesGallery_" actionable>
@@ -58,14 +61,16 @@
             </div>
           </template>
         </div>
-        <div class="settings-box two-line">
+        <div class="settings-box two-line"
+            hidden="[[!pageVisibility.appearance.homeButton]]">
           <settings-checkbox class="start" label="$i18n{showHomeButton}"
               sub-label="[[getShowHomeSubLabel_(prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]"
               pref="{{prefs.browser.show_home_button}}">
           </settings-checkbox>
         </div>
         <template is="dom-if" if="[[prefs.browser.show_home_button.value]]">
-          <div class="list-frame">
+          <div class="list-frame"
+              hidden="[[!pageVisibility.appearance.homeButton]]">
             <settings-radio-group pref="{{prefs.homepage_is_newtabpage}}">
               <paper-radio-button class="list-item" name="true">
                 $i18n{homePageNtp}
@@ -79,19 +84,21 @@
             </settings-radio-group>
           </div>
         </template>
-        <div class="settings-box">
+        <div class="settings-box"
+            hidden="[[!pageVisibility.appearance.bookmarksBar]]">
           <settings-checkbox class="start" label="$i18n{showBookmarksBar}"
               pref="{{prefs.bookmark_bar.show_on_all_tabs}}">
           </settings-checkbox>
         </div>
+        <div class="settings-box"
+            first$="[[!pageVisibility.appearance.bookmarksBar]]">

[michaelpg, 2016/07/21 04:23:03]

This is easy enough to do in |class|, thanks to string interpolation:

class$="settings-box [[getFirst_(pageVisibility.appearance.bookmarksBar)]]"

then add the method getFirst_(bookmarksBarVisible) that returns 'first' or the
empty string.

[Moe, 2016/07/21 18:27:32]

Done.

 <if expr="is_linux and not chromeos">
-        <div class="settings-box">
           <settings-checkbox class="start" label="$i18n{showWindowDecorations}"
               pref="{{prefs.browser.custom_chrome_frame}}">
           </settings-checkbox>
         </div>
-</if>
         <div class="settings-box">
+</if>
           <div class="start">$i18n{fontSize}</div>
           <settings-dropdown-menu id="defaultFontSize"
               pref="{{prefs.webkit.webprefs.default_font_size}}"
@@ -105,7 +112,8 @@
           <div class="secondary">$i18n{chooseFontsAndEncoding}</div>
           </div>
         </div>
-        <div class="settings-box">
+        <div class="settings-box"
+            hidden="[[!pageVisibility.appearance.pageZoom]]">
           <div class="start">$i18n{pageZoom}</div>
           <settings-dropdown-menu id="pageZoom" pref="{{defaultZoomLevel_}}"
               menu-options="[[pageZoomOptions_]]" no-label-float>