MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/appearance_page/appearance_page.html

 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/paper-radio-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/paper-toggle-button.html">
 <link rel="import" href="/appearance_page/appearance_browser_proxy.html">
 <link rel="import" href="/controls/settings_dropdown_menu.html">
@@ skipping 12 matching lines @@
     <style include="settings-shared">
       .settings-box iron-icon {
         -webkit-margin-end: var(--iron-icon-spacing);
       }
     </style>
     <settings-animated-pages id="pages" current-route="{{currentRoute}}"
         section="appearance">
       <neon-animatable id="main">
 <if expr="chromeos">
         <div class="settings-box first two-line" id="wallpaperButton"
-            on-tap="openWallpaperManager_" actionable>
+            on-tap="openWallpaperManager_" actionable

[michaelpg, 2016/07/13 00:01:35]

Not relevant here, but: Are there any rows in Settings that are *visible* in
guest mode but not actionable? (The "actionable" attribute was added recently to
change the cursor for items that do something on click, so we would want to
suppress it on buttons whose actions are removed in guest mode.)

[Moe, 2016/07/13 20:17:17]

Good point. The only case where we're removing an action in guest mode is
"setting the UI language" in cros and windows. I updated the CL to remove the
'actionable' class from the list of classes too.

+            hidden="[[!pageVisibility.appearance.setWallpaper]]">
           <iron-icon icon="settings:wallpaper"></iron-icon>
           <div class="start">
             <div>$i18n{setWallpaper}</div>
             <div class="secondary">$i18n{openWallpaperApp}</div>
           </div>
         </div>
-        <div class="settings-box two-line">
+        <div class="settings-box two-line"
+            hidden="[[!pageVisibility.appearance.setTheme]]">
 </if>
 <if expr="not chromeos">
-        <div class="settings-box two-line first">
+        <div class="settings-box two-line first"
+            hidden="[[!pageVisibility.appearance.setTheme]]">
 </if>
           <div class="layout horizontal center flex"
               on-tap="openThemesGallery_" actionable>
             <iron-icon icon="settings:palette"></iron-icon>
             <div>
               <div>$i18n{getThemes}</div>
               <div class="secondary">[[themeSublabel_]]</div>
             </div>
           </div>
           <template is="dom-if" if="[[allowResetTheme_]]">
             <div class="secondary-action">
               <paper-button id="resetTheme" on-tap="resetTheme_"
                   class="secondary-button">
                 $i18n{resetToDefaultTheme}
               </paper-button>
             </div>
           </template>
         </div>
-        <div class="settings-box two-line">
+        <div class="settings-box two-line"
+            hidden="[[!pageVisibility.appearance.homeButton]]">
           <settings-checkbox class="start" label="$i18n{showHomeButton}"
               sub-label="[[getShowHomeSubLabel_(prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]"
               pref="{{prefs.browser.show_home_button}}">
           </settings-checkbox>
         </div>
         <template is="dom-if" if="[[prefs.browser.show_home_button.value]]">
-          <div class="list-frame">
+          <div class="list-frame"
+              hidden="[[!pageVisibility.appearance.homeButton]]">
             <settings-radio-group pref="{{prefs.homepage_is_newtabpage}}">
               <paper-radio-button class="list-item" name="true">
                 $i18n{homePageNtp}
               </paper-radio-button>
               <paper-radio-button class="list-item" name="false">
                 $i18n{other}
                 <settings-input no-label-float pref="{{prefs.homepage}}"
                     label="$i18n{exampleDotCom}">
                 </settings-input>
               </paper-radio-button>
             </settings-radio-group>
           </div>
         </template>
-        <div class="settings-box">
+        <div class="settings-box"
+            hidden="[[!pageVisibility.appearance.bookmarksBar]]">
           <settings-checkbox class="start" label="$i18n{showBookmarksBar}"
               pref="{{prefs.bookmark_bar.show_on_all_tabs}}">
           </settings-checkbox>
         </div>
+        <div class="settings-box"
+            first$="[[!pageVisibility.appearance.bookmarksBar]]">

[michaelpg, 2016/07/13 00:01:35]

hmm, why? the other "first" divs aren't related to bookmarksBar.

[Moe, 2016/07/13 20:17:17]

correct, but I thought since homeButton, bookmarksBar, setTheme, and
setWallpaper are all hidden in guest mode, a computed binding may not be
necessary to check if all are set to false.

 <if expr="is_linux and not chromeos">
-        <div class="settings-box">
           <settings-checkbox class="start" label="$i18n{showWindowDecorations}"
               pref="{{prefs.browser.custom_chrome_frame}}">
           </settings-checkbox>
         </div>
+        <div class="settings-box">
 </if>
-        <div class="settings-box">
           <div class="start">$i18n{fontSize}</div>
           <settings-dropdown-menu id="defaultFontSize"
               pref="{{prefs.webkit.webprefs.default_font_size}}"
               menu-options="[[fontSizeOptions_]]" no-label-float>
           </settings-dropdown-menu>
         </div>
         <div class="settings-box two-line" on-tap="onCustomizeFontsTap_"
             actionable>
           <div class="start">
             <div>$i18n{customizeFonts}</div>
           <div class="secondary">$i18n{chooseFontsAndEncoding}</div>
           </div>
         </div>
-        <div class="settings-box">
+        <div class="settings-box"
+            hidden="[[!pageVisibility.appearance.pageZoom]]">
           <div class="start">$i18n{pageZoom}</div>
           <settings-dropdown-menu id="pageZoom" pref="{{defaultZoomLevel_}}"
               menu-options="[[pageZoomOptions_]]" no-label-float>
           </settings-dropdown-menu>
         </div>
       </neon-animatable>
       <template is="dom-if" name="appearance-fonts">
         <settings-subpage page-title="$i18n{customizeFonts}">
           <settings-appearance-fonts-page prefs="{{prefs}}">
           </settings-appearance-fonts-page>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="appearance_page.js"></script>
 </dom-module>