Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2106103006: MD Settings: cr/cros - Guest mode page visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * 'settings-appearance-page' is the settings page containing appearance 6 * 'settings-appearance-page' is the settings page containing appearance
7 * settings. 7 * settings.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 {value: 175, name: '175%'}, 100 {value: 175, name: '175%'},
101 {value: 200, name: '200%'}, 101 {value: 200, name: '200%'},
102 {value: 300, name: '300%'}, 102 {value: 300, name: '300%'},
103 {value: 400, name: '400%'}, 103 {value: 400, name: '400%'},
104 {value: 500, name: '500%'}, 104 {value: 500, name: '500%'},
105 ], 105 ],
106 }, 106 },
107 107
108 /** @private */ 108 /** @private */
109 themeSublabel_: String, 109 themeSublabel_: String,
110
111 /**
112 * Dictionary defining page visibility.
113 * @type {!AppearancePageVisibility}
114 */
115 pageVisibility: {
dpapad 2016/07/25 19:37:10 Nit: Isn't this equivalent to the following (here
michaelpg 2016/07/26 04:02:55 yes
Moe 2016/07/27 01:11:05 Done.
116 type: Object,
117 },
110 }, 118 },
111 119
112 observers: [ 120 observers: [
113 'themeChanged_(prefs.extensions.theme.id.value)', 121 'themeChanged_(prefs.extensions.theme.id.value)',
114 'zoomLevelChanged_(defaultZoomLevel_.value)', 122 'zoomLevelChanged_(defaultZoomLevel_.value)',
115 ], 123 ],
116 124
117 created: function() { 125 created: function() {
118 this.browserProxy_ = settings.AppearanceBrowserProxyImpl.getInstance(); 126 this.browserProxy_ = settings.AppearanceBrowserProxyImpl.getInstance();
119 }, 127 },
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 /** 221 /**
214 * @param {number} percent The integer percentage of the page zoom. 222 * @param {number} percent The integer percentage of the page zoom.
215 * @private 223 * @private
216 */ 224 */
217 zoomLevelChanged_: function(percent) { 225 zoomLevelChanged_: function(percent) {
218 // The |percent| may be undefined on startup. 226 // The |percent| may be undefined on startup.
219 if (percent === undefined) 227 if (percent === undefined)
220 return; 228 return;
221 chrome.settingsPrivate.setDefaultZoomPercent(percent); 229 chrome.settingsPrivate.setDefaultZoomPercent(percent);
222 }, 230 },
231
232 /**
233 * @param {boolean} bookmarksBarVisible if bookmarks bar option is visible.
234 * @return {string} 'first' if the argument is false or empty otherwise.
235 * @private
236 */
237 getFirst_: function(bookmarksBarVisible) {
238 return !bookmarksBarVisible ? 'first' : '';
239 }
223 }); 240 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698