chrome/browser/resources/settings/date_time_page/date_time_page.html - Issue 2106103006: MD Settings: cr/cros - Guest mode page visibility

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/date_time_page/date_time_page.html

Issue 2106103006: MD Settings: cr/cros - Guest mode page visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.html ('k') | chrome/browser/resources/settings/downloads_page/downloads_page.html » ('j') | chrome/browser/resources/settings/languages_page/languages_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

3 <link rel="import" href="/controls/settings_checkbox.html">	3 <link rel="import" href="/controls/settings_checkbox.html">

4 <link rel="import" href="/settings_shared_css.html">	4 <link rel="import" href="/settings_shared_css.html">

5	5

6 <dom-module id="settings-date-time-page">	6 <dom-module id="settings-date-time-page">

7 <template>	7 <template>

8 <style include="settings-shared"></style>	8 <style include="settings-shared"></style>

9 <div class="settings-box first block">	9 <div class="settings-box first block">

10 <div>$i18n{timeZone}</div>	10 <div disabled$="[[!pageVisibility.timeZoneSelector]]">
	dpapad 2016/07/22 22:40:48 +michaelpg Are we OK with having HTML refer to Po +michaelpg Are we OK with having HTML refer to Polymer properties that are not defined in the \|properties\| section of the equivalent JS file (referring to \|pageVisibility\| variable)? Moe 2016/07/24 23:54:26 I think after introducing the sub-types it won't h Show quoted text On 2016/07/22 22:40:48, dpapad wrote: > +michaelpg > > Are we OK with having HTML refer to Polymer properties that are not defined in > the \|properties\| section of the equivalent JS file (referring to > \|pageVisibility\| variable)? I think after introducing the sub-types it won't hurt to declare the properties in the JS.
	11 $i18n{timeZone}

	12 </div>

11 <settings-checkbox pref="{{prefs.settings.clock.use_24hour_clock}}"	13 <settings-checkbox pref="{{prefs.settings.clock.use_24hour_clock}}"

12 label="$i18n{use24HourClock}">	14 label="$i18n{use24HourClock}">

13 </settings-checkbox>	15 </settings-checkbox>

14 <div id="setAutomatically">$i18n{dateTimeSetAutomatically}</div>	16 <div id="setAutomatically">$i18n{dateTimeSetAutomatically}</div>

15 </div>	17 </div>

16 </template>	18 </template>

17 <script src="date_time_page.js"></script>	19 <script src="date_time_page.js"></script>

18 </dom-module>	20 </dom-module>

OLD	NEW