OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 /** | |
6 * @fileoverview Closure typedefs for settings_ui. | |
7 */ | |
8 | |
9 /** | |
10 * Specifies page visibility in guest mode in cr and cros. | |
11 * @typedef {{ | |
12 * advancedSettings: (boolean|undefined), | |
dpapad
2016/07/22 18:33:04
Why are all top-level boolean on this object, unde
Moe
2016/07/22 20:53:50
I've seen this elsewhere too. Look at sync_browser
dpapad
2016/07/22 22:40:48
My thinking was that there is only one place where
| |
13 * appearance: (boolean|undefined|{ | |
14 * bookmarksBar: boolean, | |
15 * homeButton: boolean, | |
16 * pageZoom: boolean, | |
17 * setTheme: boolean, | |
18 * setWallpaper: boolean, | |
19 * }), | |
20 * dateTime: (boolean|undefined|{ | |
21 * timeZoneSelector: boolean, | |
22 * }), | |
23 * defaultBrowser: (boolean|undefined), | |
24 * downloads: (undefined|{ | |
25 * googleDrive: boolean, | |
26 * }), | |
27 * onStartup: (boolean|undefined), | |
28 * passwordsAndForms: (boolean|undefined), | |
29 * people: (boolean|undefined), | |
30 * privacy: (undefined|{ | |
dpapad
2016/07/22 18:33:04
If you decide to pass subsets of the GuestModePage
Moe
2016/07/22 20:53:49
That's a good idea! but I'm not sure if it's neede
dpapad
2016/07/22 22:40:48
I am seeing several |pageVisibility| variables in
Moe
2016/07/24 23:54:26
I'd go with option 2. The first option won't work
| |
31 * networkPrediction: boolean, | |
32 * searchPrediction: boolean, | |
33 * }), | |
34 * reset:(boolean|undefined), | |
35 * }} | |
36 */ | |
37 var GuestModePageVisibility; | |
OLD | NEW |