MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/settings_menu/settings_menu.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-menu' shows a menu with a hardcoded set of pages and subpages.
  */
 Polymer({
   is: 'settings-menu',
 
   properties: {
     /** @private */
     advancedOpened_: Boolean,
 
     /**
      * The current active route.
      * @type {!SettingsRoute}
      */
     currentRoute: {
       type: Object,
       notify: true,
       observer: 'currentRouteChanged_',
     },
+
+    /**
+     * Dictionary defining page visibility.
+     * @type {Object}

[michaelpg, 2016/07/21 04:23:03]

type unnecessary -- closure's Polymer pass figures out the type from the
property itself (line 31)

we only have it on line 18 because that's more specific than just Object

[Moe, 2016/07/21 18:27:32]

Done. Thanks for the explanation!

+     */
+    pageVisibility: {
+      type: Object,
+      value: function() { return {}; },

[michaelpg, 2016/07/21 04:23:03]

This shouldn't need a default value here-- set it once (like in settings-main)
and let data binding do the rest. Otherwise we may get some wasteful change
notifications on initialization.

[Moe, 2016/07/21 18:27:32]

Done.

+    },
   },
 
   attached: function() {
     document.addEventListener('toggle-advanced-page', function(e) {
       if (e.detail)
         this.$.advancedPage.open();
       else
         this.$.advancedPage.close();
     }.bind(this));
 
     this.$.advancedPage.addEventListener('paper-submenu-open', function() {
       this.fire('toggle-advanced-page', true);
     }.bind(this));
 
     this.$.advancedPage.addEventListener('paper-submenu-close', function() {
       this.fire('toggle-advanced-page', false);
     }.bind(this));
 
     this.fire('toggle-advanced-page', this.currentRoute.page == 'advanced');
   },
 
   /**
    * @param {!SettingsRoute} newRoute
    * @private
    */
   currentRouteChanged_: function(newRoute) {
     // Sync URL changes to the side nav menu.
 
     if (newRoute.page == 'advanced') {
+      assert(! /** @type {{hideAdvancedSettings: boolean}} */
+          (this.pageVisibility.hideAdvancedSettings));
       this.$.advancedMenu.selected = this.currentRoute.section;
       this.$.basicMenu.selected = null;
     } else if (newRoute.page == 'basic') {
       this.$.advancedMenu.selected = null;
       this.$.basicMenu.selected = this.currentRoute.section;
     } else {
       this.$.advancedMenu.selected = null;
       this.$.basicMenu.selected = null;
     }
   },
@@ skipping 30 matching lines @@
 
   /**
    * @param {boolean} opened Whether the menu is expanded.
    * @return {string} Which icon to use.
    * @private
    * */
   arrowState_: function(opened) {
     return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down';
   },
 });