MD Settings: cr/cros - Guest mode page visibility

chrome/browser/resources/settings/settings_ui/settings_ui.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-ui' implements the UI for the Settings page.
  *
  * Example:
  *
@@ skipping 20 matching lines @@
       value: function() {
         return !!(sessionStorage.appealClosed_ || localStorage.appealClosed_);
       },
     },
   },
 
   listeners: {
     'sideNav.iron-activate': 'onIronActivate_',
   },
 
+  /** @override */
+  ready: function() {
+    this.$$('cr-toolbar').addEventListener('search-changed', function(e) {
+      this.$$('settings-main').searchContents(e.detail);
+    }.bind(this));
+
+    if (loadTimeData.getBoolean('isGuest')) {
+      this.pageVisibility_ = {

[tommycli, 2016/07/14 22:55:40]

I noticed that the guest visibility info is in both the settings-router and
here. This will be kind of annoying to keep in-sync, especially as new routes
are added.

In my ideal world, the visibility test would look something like:

settings.Route.PEOPLE.guestCanAccess.

That above example would depend on an in-progress router refactor, but you could
add some globals in the setting-router code as a temporary measure.

It would just be good to confine the guess-can-access information to one place.
I'd open to suggestions on how best to accomplish that...

[Moe, 2016/07/15 14:02:07]

I don't expect guest-mode page visibility to change often. Only new routes have
to keep in-sync with it as they are added. Also not every section/dialog may
have a route, but it may have to be hidden/disabled in guest mode. And in some
instances it is a certain functionality that is disabled in guest mode, not the
route.
But whether this can be a global in settings-router, probably.

+        people: false,
+        onStartup: false,
+        reset: false,
+<if expr="not chromeos">
+        appearance: false,
+        defaultBrowser: false,
+
+        hideAdvancedSettings: true,
+        hideToolbarSearchField: true,
+</if>
+<if expr="chromeos">
+        appearance: {
+          setWallpaper: false,
+          setTheme: false,
+          homeButton: false,
+          bookmarksBar: false,
+          pageZoom: false,
+        },
+        dateTime: {
+          timeZoneSelector: false,
+        },
+        privacy: {
+          networkPrediction: false,
+        },
+        passwordsAndForms: false,
+        downloads: {
+          googleDrive: false,
+        },
+</if>
+      };
+    }
+  },
+
   /** @private */
   onCloseAppealTap_: function() {
     sessionStorage.appealClosed_ = this.appealClosed_ = true;
   },
 
   /**
    * @param {Event} event
    * @private
    */
   onIronActivate_: function(event) {
     if (event.detail.item.id != 'advancedPage')
       this.$$('app-drawer').close();
   },
 
   /** @private */
   onMenuButtonTap_: function() {
     this.$$('app-drawer').toggle();
   },
 
-  /** @override */
-  ready: function() {
-    this.$$('cr-toolbar').addEventListener('search-changed', function(e) {
-      this.$$('settings-main').searchContents(e.detail);
-    }.bind(this));
-  },
-
   /** @private */
   directionDelegateChanged_: function() {
     this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
         'right' : 'left';
   },
 });