Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2106093003: Remove legacy ShouldPopupDialogAboutOtherFormsOfBrowsingHistory. (Closed)

Created:
4 years, 5 months ago by msarda
Modified:
4 years, 5 months ago
Reviewers:
msramek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy ShouldPopupDialogAboutOtherFormsOfBrowsingHistory. BUG=614319 Committed: https://crrev.com/3a3cc9562b32a5838dee19f28916477cc49ed17b Cr-Commit-Position: refs/heads/master@{#402795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M components/browsing_data_ui/history_notice_utils.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/browsing_data_ui/history_notice_utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
msarda
Please take a look.
4 years, 5 months ago (2016-06-29 12:40:14 UTC) #2
msramek
LGTM, thanks!
4 years, 5 months ago (2016-06-29 13:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106093003/1
4 years, 5 months ago (2016-06-29 13:06:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 13:59:16 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 14:01:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a3cc9562b32a5838dee19f28916477cc49ed17b
Cr-Commit-Position: refs/heads/master@{#402795}

Powered by Google App Engine
This is Rietveld 408576698