Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2106083002: Remove SealHandleScope from TryNumberToSize conversion (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove SealHandleScope from TryNumberToSize conversion This function should also be callable from a concurrent thread, so we cannot use the scope here. Instead, provide a test that checks that no handles are created. R=ulan@chromium.org TEST=cctest/test-conversions/NoHandlesForTryNumberToSize BUG= Committed: https://crrev.com/67b5a501db179412479e827e51c43515e4196b27 Cr-Commit-Position: refs/heads/master@{#37381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M src/conversions-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-conversions.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Lippautz
4 years, 5 months ago (2016-06-29 09:00:45 UTC) #1
ulan
lgtm
4 years, 5 months ago (2016-06-29 09:05:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106083002/1
4 years, 5 months ago (2016-06-29 09:05:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 10:04:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106083002/1
4 years, 5 months ago (2016-06-29 10:26:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 10:27:47 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 10:29:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67b5a501db179412479e827e51c43515e4196b27
Cr-Commit-Position: refs/heads/master@{#37381}

Powered by Google App Engine
This is Rietveld 408576698