Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2106073006: [Extensions] Pull ExtensionId into its own file (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Pull ExtensionId into its own file Pull the typedef for ExtensionId into its own file so that includers don't need the full extension.h include. Also fix a few IWYU errors, though I'm sure there are many, many more. BUG=624923 TBR=atwilson@chromium.org (c/b/background) TBR=stevenjb@chromium.org (c/b/ui/app_list) Committed: https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195 Cr-Commit-Position: refs/heads/master@{#403590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -22 lines) Patch
M chrome/browser/background/background_mode_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_event_router.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_event_router.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_value_store_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/content_hash_fetcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/legacy_value_store_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/legacy_value_store_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/value_store/test_value_store_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/value_store/value_store_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/value_store_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension.h View 2 chunks +1 line, -7 lines 0 comments Download
A extensions/common/extension_id.h View 1 chunk +18 lines, -0 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Devlin
4 years, 5 months ago (2016-07-01 15:55:19 UTC) #2
lazyboy
lgtm Great thanks! lgtm.
4 years, 5 months ago (2016-07-02 01:20:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106073006/1
4 years, 5 months ago (2016-07-02 01:20:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/211770)
4 years, 5 months ago (2016-07-02 01:27:33 UTC) #7
Devlin
TBRing stevenjb@ and atwilson@.
4 years, 5 months ago (2016-07-02 01:45:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106073006/1
4 years, 5 months ago (2016-07-02 01:46:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-02 02:06:00 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-02 02:06:04 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 02:07:50 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195
Cr-Commit-Position: refs/heads/master@{#403590}

Powered by Google App Engine
This is Rietveld 408576698